From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4157 invoked by alias); 3 Feb 2008 19:55:53 -0000 Received: (qmail 4146 invoked by uid 22791); 3 Feb 2008 19:55:53 -0000 X-Spam-Check-By: sourceware.org Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 03 Feb 2008 19:55:25 +0000 Received: from eusrcmw751.eamcs.ericsson.se (eusrcmw751.exu.ericsson.se [138.85.77.51]) by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id m13Jt9H5011366; Sun, 3 Feb 2008 13:55:09 -0600 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw751.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Sun, 3 Feb 2008 13:55:08 -0600 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [Patch] -var-evaluate-expression NAME [FORMAT] Date: Sun, 03 Feb 2008 19:55:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04E1BC29@ecamlmw720.eamcs.ericsson.se> References: <20080129214347.GC15063@caradoc.them.org> <6D19CA8D71C89C43A057926FE0D4ADAA04290E7D@ecamlmw720.eamcs.ericsson.se> From: "Marc Khouzam" To: "Vladimir Prus" , X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00054.txt.bz2 > I honestly don't like this 'set global format, then cleanup' > trick, but that's something we can fix later. There was another suggested solution in: http://sourceware.org/ml/gdb-patches/2008-01/msg00531.html But it seemed like too much impact. > > - else if (var->value =3D=3D NULL && value =3D=3D NULL) > > + else if (var->value =3D=3D NULL && value =3D=3D NULL) >=20 > Did you do something about indentation here? I went through the file and replaced any starting sequence of 8 spaces with a tab. I hesitated at changing parts of the file I didn't actually change, but since they were minor changes, I though it would make the file more readable. [...] > > if (mi_version (uiout) > 1) > > - do_cleanups (cleanup); > > + do_cleanups (cleanup); >=20 > Lots of reformatting here as well. The patch looks otherwise > good to me. All these reformats are replacing 8 spaces with tabs. Unless you guys want me to revert that extra reformatting,=20 I guess the patch is good?=20=20 Who's gonna apply it? :-) Thanks Marc=20