From: Joel Brobecker <brobecker@adacore.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb-patches@sources.redhat.com
Subject: Re: [Patch] -var-evaluate-expression NAME [FORMAT]
Date: Sun, 03 Feb 2008 20:42:00 -0000 [thread overview]
Message-ID: <20080203204212.GC21614@adacore.com> (raw)
In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA04E1BC29@ecamlmw720.eamcs.ericsson.se>
> I went through the file and replaced any starting sequence of
> 8 spaces with a tab. I hesitated at changing parts of the file
> I didn't actually change, but since they were minor changes,
> I though it would make the file more readable.
We usually prefer it if you do the reformatting in a separate patch.
It makes it easier to review the non-reformatting bits by not drowning
the meat of your patch with other, less critical, hunks.
--
Joel
next prev parent reply other threads:[~2008-02-03 20:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 20:38 Marc Khouzam
2008-01-23 3:04 ` Nick Roberts
2008-01-23 14:30 ` Marc Khouzam
2008-01-23 14:42 ` Daniel Jacobowitz
2008-01-23 17:04 ` Marc Khouzam
2008-01-23 22:09 ` Nick Roberts
2008-01-24 21:36 ` Marc Khouzam
2008-01-25 9:59 ` Eli Zaretskii
2008-01-29 21:45 ` Daniel Jacobowitz
2008-02-01 19:23 ` Marc Khouzam
2008-02-02 10:31 ` Eli Zaretskii
2008-02-03 19:43 ` Marc Khouzam
2008-02-03 20:01 ` Eli Zaretskii
2008-02-04 14:17 ` Marc Khouzam
2008-02-04 21:00 ` Eli Zaretskii
2008-02-02 11:20 ` Vladimir Prus
2008-02-03 19:55 ` Marc Khouzam
2008-02-03 20:42 ` Joel Brobecker [this message]
2008-02-03 21:41 ` Daniel Jacobowitz
2008-02-03 21:46 ` Daniel Jacobowitz
2008-02-04 17:00 ` Marc Khouzam
2008-02-04 17:02 ` Marc Khouzam
2008-02-04 21:40 ` Nick Roberts
2008-02-04 21:53 ` Nick Roberts
2008-02-05 14:47 ` Marc Khouzam
2008-02-05 20:43 ` Nick Roberts
2008-02-05 20:55 ` Marc Khouzam
2008-02-05 21:18 ` Nick Roberts
2008-02-04 17:11 ` Marc Khouzam
2008-01-23 3:48 ` Daniel Jacobowitz
2008-01-23 14:44 ` Marc Khouzam
2008-01-28 14:41 Marc Khouzam
2008-01-28 14:48 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080203204212.GC21614@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox