From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2338 invoked by alias); 3 Feb 2008 20:42:34 -0000 Received: (qmail 2329 invoked by uid 22791); 3 Feb 2008 20:42:34 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 03 Feb 2008 20:42:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C76FA2AA3ED; Sun, 3 Feb 2008 15:42:14 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nx9vUxKIEsfP; Sun, 3 Feb 2008 15:42:14 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 906232AA3E5; Sun, 3 Feb 2008 15:42:14 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6722CE7ACB; Sun, 3 Feb 2008 12:42:12 -0800 (PST) Date: Sun, 03 Feb 2008 20:42:00 -0000 From: Joel Brobecker To: Marc Khouzam Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [Patch] -var-evaluate-expression NAME [FORMAT] Message-ID: <20080203204212.GC21614@adacore.com> References: <20080129214347.GC15063@caradoc.them.org> <6D19CA8D71C89C43A057926FE0D4ADAA04290E7D@ecamlmw720.eamcs.ericsson.se> <6D19CA8D71C89C43A057926FE0D4ADAA04E1BC29@ecamlmw720.eamcs.ericsson.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA04E1BC29@ecamlmw720.eamcs.ericsson.se> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00057.txt.bz2 > I went through the file and replaced any starting sequence of > 8 spaces with a tab. I hesitated at changing parts of the file > I didn't actually change, but since they were minor changes, > I though it would make the file more readable. We usually prefer it if you do the reformatting in a separate patch. It makes it easier to review the non-reformatting bits by not drowning the meat of your patch with other, less critical, hunks. -- Joel