From: "Marc Khouzam" <marc.khouzam@ericsson.com>
To: "Daniel Jacobowitz" <drow@false.org>
Cc: <gdb-patches@sources.redhat.com>
Subject: RE: [Patch] Fix for -var-update to use natural format to compare
Date: Tue, 22 Jan 2008 15:12:00 -0000 [thread overview]
Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04290E43@ecamlmw720.eamcs.ericsson.se> (raw)
In-Reply-To: <20080122150232.GA32509@caradoc.them.org>
> That's what happens when the thread goes on too long :-)
I try to keep my responses short, but somehow I always get carried away :-)
> We could check in all supported formats; check in the natural format;
> or go back to checking the underlying bytes. Checking in the natural
> format is appealing because it's efficient. But does the natural
> format always capture changes in any of the other formats?
I didn't find an example where checking the natural format would not work.
But that may not mean much :-)
Boolean could have been a problem (0x1, 0x2, 0x3 etc are all "true" in natural),
but it seems that for now, GDB always shows 0x1 for true.
A safer way may be to have GDB check for content difference, as it used to do
before and to also check the natural printed format for the case of char*
(to detect a change from "GDB" to "GNU").
Marc
next prev parent reply other threads:[~2008-01-22 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 3:25 Marc Khouzam
2008-01-22 3:53 ` Daniel Jacobowitz
2008-01-22 14:43 ` Marc Khouzam
2008-01-22 15:03 ` Daniel Jacobowitz
2008-01-22 15:12 ` Marc Khouzam [this message]
2008-01-22 15:35 ` Vladimir Prus
2008-01-22 16:38 ` Marc Khouzam
2008-01-22 17:50 ` Vladimir Prus
2008-01-22 17:59 ` Daniel Jacobowitz
2008-01-23 0:33 ` Nick Roberts
2008-01-23 14:41 ` Marc Khouzam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D19CA8D71C89C43A057926FE0D4ADAA04290E43@ecamlmw720.eamcs.ericsson.se \
--to=marc.khouzam@ericsson.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox