From: Daniel Jacobowitz <drow@false.org>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [Patch] Fix for -var-update to use natural format to compare
Date: Tue, 22 Jan 2008 03:53:00 -0000 [thread overview]
Message-ID: <20080122035325.GA28748@caradoc.them.org> (raw)
In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA2DE0A5@ecamlmw720.eamcs.ericsson.se>
On Mon, Jan 21, 2008 at 10:24:40PM -0500, Marc Khouzam wrote:
> This patch addresses a discussion titled "-var-update using formatted value" from
> the GDB mailing list.
> It modifies the variable object code to always uses the natural format to compare
> old and new values for the -var-update command (one line change).
> It also renames the member print_value of varobj to natural_value.
I don't think this is an appropriate change.
-var-update is supposed to tell when the displayed value has changed.
If the value in the current format hasn't changed, there's no need to
refetch. It's not about the underlying memory bytes, which is why we
changed to a string comparison. There are various other ways to
change the underlying variable without updating the representation
(e.g. changes in padding bits).
I think you've explained this already - probably to me - but could you
do it once more, please: why do you want to keep track of the value in
all formats? And if you're actually displaying them all
simultaneously to the user, why shouldn't they be independent varobjs?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-22 3:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 3:25 Marc Khouzam
2008-01-22 3:53 ` Daniel Jacobowitz [this message]
2008-01-22 14:43 ` Marc Khouzam
2008-01-22 15:03 ` Daniel Jacobowitz
2008-01-22 15:12 ` Marc Khouzam
2008-01-22 15:35 ` Vladimir Prus
2008-01-22 16:38 ` Marc Khouzam
2008-01-22 17:50 ` Vladimir Prus
2008-01-22 17:59 ` Daniel Jacobowitz
2008-01-23 0:33 ` Nick Roberts
2008-01-23 14:41 ` Marc Khouzam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122035325.GA28748@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox