From: Daniel Jacobowitz <drow@false.org>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [Patch] Fix for -var-update to use natural format to compare
Date: Tue, 22 Jan 2008 15:03:00 -0000 [thread overview]
Message-ID: <20080122150232.GA32509@caradoc.them.org> (raw)
In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA04290E42@ecamlmw720.eamcs.ericsson.se>
On Tue, Jan 22, 2008 at 09:43:21AM -0500, Marc Khouzam wrote:
> You can refer to http://sourceware.org/ml/gdb/2008-01/msg00175.html
> where you had agreed with me :-)
That's what happens when the thread goes on too long :-)
Here's the problem, as I see it. There are two different reasonable
definitions of "varobj has changed". One is that the textual
representation has changed. The other is that the underlying bytes
have changed.
We used to check the underlying bytes. This was a problem because the
textual representation for a "char *" includes more bytes than the
value, for C-like languages. So, as Nick mentioned last week, we
would not detect a change from "GNU" to "GDB" in a "char *", but we
would display the "GNU" string in -var-evaluate-expression.
We switched to checking the string representation. But if you're
looking in lots of formats, then this is not enough.
We could check in all supported formats; check in the natural format;
or go back to checking the underlying bytes. Checking in the natural
format is appealing because it's efficient. But does the natural
format always capture changes in any of the other formats?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-01-22 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 3:25 Marc Khouzam
2008-01-22 3:53 ` Daniel Jacobowitz
2008-01-22 14:43 ` Marc Khouzam
2008-01-22 15:03 ` Daniel Jacobowitz [this message]
2008-01-22 15:12 ` Marc Khouzam
2008-01-22 15:35 ` Vladimir Prus
2008-01-22 16:38 ` Marc Khouzam
2008-01-22 17:50 ` Vladimir Prus
2008-01-22 17:59 ` Daniel Jacobowitz
2008-01-23 0:33 ` Nick Roberts
2008-01-23 14:41 ` Marc Khouzam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122150232.GA32509@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox