From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26227 invoked by alias); 22 Jan 2008 15:12:11 -0000 Received: (qmail 26217 invoked by uid 22791); 22 Jan 2008 15:12:11 -0000 X-Spam-Check-By: sourceware.org Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 22 Jan 2008 15:11:42 +0000 Received: from eusrcmw750.eamcs.ericsson.se (eusrcmw750.exu.ericsson.se [138.85.77.50]) by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id m0MFBZU3012055; Tue, 22 Jan 2008 09:11:40 -0600 Received: from ecamlmw720.eamcs.ericsson.se ([142.133.1.72]) by eusrcmw750.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.1830); Tue, 22 Jan 2008 09:11:38 -0600 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [Patch] Fix for -var-update to use natural format to compare Date: Tue, 22 Jan 2008 15:12:00 -0000 Message-ID: <6D19CA8D71C89C43A057926FE0D4ADAA04290E43@ecamlmw720.eamcs.ericsson.se> In-Reply-To: <20080122150232.GA32509@caradoc.them.org> From: "Marc Khouzam" To: "Daniel Jacobowitz" Cc: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00523.txt.bz2 > That's what happens when the thread goes on too long :-) I try to keep my responses short, but somehow I always get carried away :-) > We could check in all supported formats; check in the natural format; > or go back to checking the underlying bytes. Checking in the natural > format is appealing because it's efficient. But does the natural > format always capture changes in any of the other formats? I didn't find an example where checking the natural format would not work. But that may not mean much :-) Boolean could have been a problem (0x1, 0x2, 0x3 etc are all "true" in natu= ral), but it seems that for now, GDB always shows 0x1 for true. A safer way may be to have GDB check for content difference, as it used to = do before and to also check the natural printed format for the case of char* (to detect a change from "GDB" to "GNU"). Marc