From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 08/12] gdb: move displaced stepping types to displaced-stepping.{h, c}
Date: Wed, 25 Nov 2020 01:30:52 +0000 [thread overview]
Message-ID: <5aa2cf64-c9c0-5cd3-7d4d-e1fb2466c97a@palves.net> (raw)
In-Reply-To: <20201110214614.2842615-9-simon.marchi@efficios.com>
On 11/10/20 9:46 PM, Simon Marchi via Gdb-patches wrote:
> Move displaced-stepping related stuff unchanged to displaced-stepping.h
> and displaced-stepping.c. This helps make the following patch a bit
> smaller and easier to read.
>
> gdb/ChangeLog:
>
> * Makefile.in (COMMON_SFILES): Add displaced-stepping.c.
> * aarch64-tdep.h: Include displaced-stepping.h.
> * displaced-stepping.h (struct displaced_step_copy_insn_closure):
> Move here.
> (displaced_step_copy_insn_closure_up): Move here.
> (struct buf_displaced_step_copy_insn_closure): Move here.
> (struct displaced_step_inferior_state): Move here.
> (debug_displaced): Move here.
> (displaced_debug_printf_1): Move here.
> (displaced_debug_printf): Move here.
> * displaced-stepping.c: New file.
> * gdbarch.sh: Include displaced-stepping.h in gdbarch.h.
> * gdbarch.h: Re-generate.
> * inferior.h: Include displaced-stepping.h.
> * infrun.h (debug_displaced): Move to displaced-stepping.h.
> (displaced_debug_printf_1): Likewise.
> (displaced_debug_printf): Likewise.
> (struct displaced_step_copy_insn_closure): Likewise.
> (displaced_step_copy_insn_closure_up): Likewise.
> (struct buf_displaced_step_copy_insn_closure): Likewise.
> (struct displaced_step_inferior_state): Likewise.
> * infrun.c (show_debug_displaced): Move to displaced-stepping.c.
> (displaced_debug_printf_1): Likewise.
> (displaced_step_copy_insn_closure::~displaced_step_copy_insn_closure):
> Likewise.
> (_initialize_infrun): Don't register "set/show debug displaced".
OK.
next prev parent reply other threads:[~2020-11-25 1:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 21:46 [PATCH 00/12] Concurrent displaced stepping Simon Marchi via Gdb-patches
2020-11-10 21:46 ` [PATCH 01/12] gdb: add inferior_execd observable Simon Marchi via Gdb-patches
2020-11-25 1:28 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 02/12] gdb: clear inferior displaced stepping state on exec Simon Marchi via Gdb-patches
2020-11-25 1:28 ` Pedro Alves
2020-12-01 4:27 ` Simon Marchi
2020-11-10 21:46 ` [PATCH 03/12] gdb: rename things related to step over chains Simon Marchi via Gdb-patches
2020-11-25 1:28 ` Pedro Alves
2020-11-25 13:16 ` Simon Marchi via Gdb-patches
2020-11-10 21:46 ` [PATCH 04/12] gdb: rename displaced_step_closure to displaced_step_copy_insn_closure Simon Marchi via Gdb-patches
2020-11-25 1:29 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 05/12] gdb: rename displaced_step_fixup to displaced_step_finish Simon Marchi via Gdb-patches
2020-11-25 1:29 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 06/12] gdb: introduce status enum for displaced step prepare/finish Simon Marchi via Gdb-patches
2020-11-11 23:36 ` Andrew Burgess
2020-11-25 13:17 ` Simon Marchi via Gdb-patches
2020-11-25 1:30 ` Pedro Alves
2020-11-25 13:20 ` Simon Marchi via Gdb-patches
2020-11-10 21:46 ` [PATCH 07/12] gdb: pass inferior to get_linux_inferior_data Simon Marchi via Gdb-patches
2020-11-25 1:30 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 08/12] gdb: move displaced stepping types to displaced-stepping.{h, c} Simon Marchi via Gdb-patches
2020-11-25 1:30 ` Pedro Alves [this message]
2020-11-10 21:46 ` [PATCH 09/12] gdb: move displaced stepping logic to gdbarch, allow starting concurrent displaced steps Simon Marchi via Gdb-patches
2020-11-25 1:40 ` Pedro Alves
2020-11-25 19:29 ` Simon Marchi via Gdb-patches
2020-11-25 19:35 ` Simon Marchi
2020-11-26 14:25 ` Pedro Alves
2020-11-30 19:13 ` Simon Marchi via Gdb-patches
2020-11-26 14:24 ` Pedro Alves
2020-11-30 20:26 ` Simon Marchi
2020-11-10 21:46 ` [PATCH 10/12] gdb: change linux gdbarch data from post to pre-init Simon Marchi via Gdb-patches
2020-11-25 1:41 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 11/12] gdb: make displaced stepping implementation capable of managing multiple buffers Simon Marchi via Gdb-patches
2020-11-25 1:41 ` Pedro Alves
2020-11-30 18:58 ` Simon Marchi
2020-11-30 19:01 ` Simon Marchi
2020-11-10 21:46 ` [PATCH 12/12] gdb: use two displaced step buffers on amd64/Linux Simon Marchi via Gdb-patches
2020-11-25 1:42 ` Pedro Alves
2020-11-25 6:26 ` Simon Marchi
2020-11-25 20:07 ` Simon Marchi
2020-11-25 20:56 ` Simon Marchi
2020-11-26 21:43 ` Simon Marchi
2020-11-26 22:34 ` Simon Marchi
2020-11-28 18:56 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aa2cf64-c9c0-5cd3-7d4d-e1fb2466c97a@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox