From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 06/12] gdb: introduce status enum for displaced step prepare/finish
Date: Wed, 25 Nov 2020 08:20:59 -0500 [thread overview]
Message-ID: <339eee1d-e54b-b8e0-38d3-638a3ddd8540@efficios.com> (raw)
In-Reply-To: <cb916559-eac0-f2f1-cd5e-dae064c340cf@palves.net>
On 2020-11-24 8:30 p.m., Pedro Alves wrote:
> On 11/10/20 9:46 PM, Simon Marchi via Gdb-patches wrote:
>> +enum displaced_step_finish_status
>> +{
>> + /* Either the instruction was stepped and fixed up, or the specified thread
>> + wasn't executing a displaced step (in which case there's nothing to
>> + finish). */
>> + DISPLACED_STEP_FINISH_STATUS_OK,
>> +
>> + /* The thread was executing a displaced step, but didn't complete it. */
>> + DISPLACED_STEP_FINISH_STATUS_NOT_EXECUTED,
>
> There's an ambiguity here that gave me pause -- the enumeration is
> called "not executed", but the comment says "was executing". I'd suggest:
>
> /* The thread started a displaced step, but didn't complete it. */
Fixed.
>> -/* If we displaced stepped an instruction successfully, adjust
>> - registers and memory to yield the same effect the instruction would
>> - have had if we had executed it at its original address, and return
>> - 1. If the instruction didn't complete, relocate the PC and return
>> - -1. If the thread wasn't displaced stepping, return 0. */
>> +/* If we displaced stepped an instruction successfully, adjust registers and
>> + memory to yield the same effect the instruction would have had if we had
>> + executed it at its original address, and return
>> + DISPLACED_STEP_PREPARE_STATUS_OK. If the instruction didn't complete,
>> + relocate the PC and return DISPLACED_STEP_PREPARE_STATUS_NOT_EXECUTED.
>
> DISPLACED_STEP_PREPARE_... -> DISPLACED_STEP_FINISH_...
Fixed.
>
>> -static int
>> + If the thread wasn't displaced stepping, return
>> + DISPLACED_STEP_PREPARE_STATUS_OK as well.. */
>
> Here too. Also, spurious double period "..".
Fixed.
Thanks,
Simon
next prev parent reply other threads:[~2020-11-25 13:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 21:46 [PATCH 00/12] Concurrent displaced stepping Simon Marchi via Gdb-patches
2020-11-10 21:46 ` [PATCH 01/12] gdb: add inferior_execd observable Simon Marchi via Gdb-patches
2020-11-25 1:28 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 02/12] gdb: clear inferior displaced stepping state on exec Simon Marchi via Gdb-patches
2020-11-25 1:28 ` Pedro Alves
2020-12-01 4:27 ` Simon Marchi
2020-11-10 21:46 ` [PATCH 03/12] gdb: rename things related to step over chains Simon Marchi via Gdb-patches
2020-11-25 1:28 ` Pedro Alves
2020-11-25 13:16 ` Simon Marchi via Gdb-patches
2020-11-10 21:46 ` [PATCH 04/12] gdb: rename displaced_step_closure to displaced_step_copy_insn_closure Simon Marchi via Gdb-patches
2020-11-25 1:29 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 05/12] gdb: rename displaced_step_fixup to displaced_step_finish Simon Marchi via Gdb-patches
2020-11-25 1:29 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 06/12] gdb: introduce status enum for displaced step prepare/finish Simon Marchi via Gdb-patches
2020-11-11 23:36 ` Andrew Burgess
2020-11-25 13:17 ` Simon Marchi via Gdb-patches
2020-11-25 1:30 ` Pedro Alves
2020-11-25 13:20 ` Simon Marchi via Gdb-patches [this message]
2020-11-10 21:46 ` [PATCH 07/12] gdb: pass inferior to get_linux_inferior_data Simon Marchi via Gdb-patches
2020-11-25 1:30 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 08/12] gdb: move displaced stepping types to displaced-stepping.{h, c} Simon Marchi via Gdb-patches
2020-11-25 1:30 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 09/12] gdb: move displaced stepping logic to gdbarch, allow starting concurrent displaced steps Simon Marchi via Gdb-patches
2020-11-25 1:40 ` Pedro Alves
2020-11-25 19:29 ` Simon Marchi via Gdb-patches
2020-11-25 19:35 ` Simon Marchi
2020-11-26 14:25 ` Pedro Alves
2020-11-30 19:13 ` Simon Marchi via Gdb-patches
2020-11-26 14:24 ` Pedro Alves
2020-11-30 20:26 ` Simon Marchi
2020-11-10 21:46 ` [PATCH 10/12] gdb: change linux gdbarch data from post to pre-init Simon Marchi via Gdb-patches
2020-11-25 1:41 ` Pedro Alves
2020-11-10 21:46 ` [PATCH 11/12] gdb: make displaced stepping implementation capable of managing multiple buffers Simon Marchi via Gdb-patches
2020-11-25 1:41 ` Pedro Alves
2020-11-30 18:58 ` Simon Marchi
2020-11-30 19:01 ` Simon Marchi
2020-11-10 21:46 ` [PATCH 12/12] gdb: use two displaced step buffers on amd64/Linux Simon Marchi via Gdb-patches
2020-11-25 1:42 ` Pedro Alves
2020-11-25 6:26 ` Simon Marchi
2020-11-25 20:07 ` Simon Marchi
2020-11-25 20:56 ` Simon Marchi
2020-11-26 21:43 ` Simon Marchi
2020-11-26 22:34 ` Simon Marchi
2020-11-28 18:56 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=339eee1d-e54b-b8e0-38d3-638a3ddd8540@efficios.com \
--to=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox