From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UJGDMdOzvV93eQAAWB0awg (envelope-from ) for ; Tue, 24 Nov 2020 20:30:59 -0500 Received: by simark.ca (Postfix, from userid 112) id C874E1F0AB; Tue, 24 Nov 2020 20:30:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 153D81E58E for ; Tue, 24 Nov 2020 20:30:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF37439540A3; Wed, 25 Nov 2020 01:30:58 +0000 (GMT) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by sourceware.org (Postfix) with ESMTPS id 672CE39540A3 for ; Wed, 25 Nov 2020 01:30:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 672CE39540A3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f66.google.com with SMTP id z7so313735wrn.3 for ; Tue, 24 Nov 2020 17:30:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZKk2gAOGKdLRxQisW60mNYkjeNf49a0GdVmFQrtfIXc=; b=qPyyKuYQyvKRff+UoMRrkHFSDhw5/wz+u1Ita+YBz5FzRd7w+E7jndlT2Lh12anC9T yZD9Dnnh2uzZ2l/v43lGpioO6kd7NaM5iVhC8bPFYBB1E10Emqc/rqr/Qb7LCP3Nz2S3 ujdNE2ZAsvyMN2NnVGCJYEcIQxxEu6Ge31wCSo9lvK+yP7c7mTFoxarNuLZK+Vh1N4fu 3J3BroYHf1c47TEuEtEVoxzRSzeEzrsUZHFshOhfv8BiycAt9luJteDS1ZR9pq1y0W5K 62rHBuZy1Pl04xkwSR1UM+NPpzFRgPfxHshlWbFhMEt2L1pmIvdC1wgOnpfrt/IDLFFh XwpQ== X-Gm-Message-State: AOAM530HA+W9KRi/CM6gVVaEjl+uTPwqU4kx3bF9Kn5EdLQ+epILsHfF +IQ+9VZun14TXDhWtVDLWO60TcG9P7fMmA== X-Google-Smtp-Source: ABdhPJzLkfkogjjCeUorCu50AtSsP/p7Wd9rO46KAh2gjPo42399XNgC0FyCOcf6E+UfR70/roKM9Q== X-Received: by 2002:adf:e449:: with SMTP id t9mr1242585wrm.257.1606267854842; Tue, 24 Nov 2020 17:30:54 -0800 (PST) Received: from ?IPv6:2001:8a0:f91f:e900:1d90:d745:3c32:c159? ([2001:8a0:f91f:e900:1d90:d745:3c32:c159]) by smtp.gmail.com with ESMTPSA id y18sm1341596wrr.67.2020.11.24.17.30.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 17:30:53 -0800 (PST) Subject: Re: [PATCH 08/12] gdb: move displaced stepping types to displaced-stepping.{h, c} To: Simon Marchi , gdb-patches@sourceware.org References: <20201110214614.2842615-1-simon.marchi@efficios.com> <20201110214614.2842615-9-simon.marchi@efficios.com> From: Pedro Alves Message-ID: <5aa2cf64-c9c0-5cd3-7d4d-e1fb2466c97a@palves.net> Date: Wed, 25 Nov 2020 01:30:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20201110214614.2842615-9-simon.marchi@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/10/20 9:46 PM, Simon Marchi via Gdb-patches wrote: > Move displaced-stepping related stuff unchanged to displaced-stepping.h > and displaced-stepping.c. This helps make the following patch a bit > smaller and easier to read. > > gdb/ChangeLog: > > * Makefile.in (COMMON_SFILES): Add displaced-stepping.c. > * aarch64-tdep.h: Include displaced-stepping.h. > * displaced-stepping.h (struct displaced_step_copy_insn_closure): > Move here. > (displaced_step_copy_insn_closure_up): Move here. > (struct buf_displaced_step_copy_insn_closure): Move here. > (struct displaced_step_inferior_state): Move here. > (debug_displaced): Move here. > (displaced_debug_printf_1): Move here. > (displaced_debug_printf): Move here. > * displaced-stepping.c: New file. > * gdbarch.sh: Include displaced-stepping.h in gdbarch.h. > * gdbarch.h: Re-generate. > * inferior.h: Include displaced-stepping.h. > * infrun.h (debug_displaced): Move to displaced-stepping.h. > (displaced_debug_printf_1): Likewise. > (displaced_debug_printf): Likewise. > (struct displaced_step_copy_insn_closure): Likewise. > (displaced_step_copy_insn_closure_up): Likewise. > (struct buf_displaced_step_copy_insn_closure): Likewise. > (struct displaced_step_inferior_state): Likewise. > * infrun.c (show_debug_displaced): Move to displaced-stepping.c. > (displaced_debug_printf_1): Likewise. > (displaced_step_copy_insn_closure::~displaced_step_copy_insn_closure): > Likewise. > (_initialize_infrun): Don't register "set/show debug displaced". OK.