* [PATCH] use return instead of continue to avoid shellcheck error
@ 2022-07-28 9:22 yaowenbin via Gdb-patches
2022-07-28 14:30 ` Simon Marchi via Gdb-patches
0 siblings, 1 reply; 2+ messages in thread
From: yaowenbin via Gdb-patches @ 2022-07-28 9:22 UTC (permalink / raw)
To: gdb-patches; +Cc: hewenliang (C), linfeilong
Signed-off-by: yaowenbin<yaowenbin1@huawei.com>
---
gdb/gdb_mbuild.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/gdb_mbuild.sh b/gdb/gdb_mbuild.sh
index 47403a7..51d2853 100755
--- a/gdb/gdb_mbuild.sh
+++ b/gdb/gdb_mbuild.sh
@@ -171,7 +171,7 @@ fail ()
if test "${keepgoing}" != ""
then
#exit 1
- continue
+ return 1
else
kill $$
exit 1
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] use return instead of continue to avoid shellcheck error
2022-07-28 9:22 [PATCH] use return instead of continue to avoid shellcheck error yaowenbin via Gdb-patches
@ 2022-07-28 14:30 ` Simon Marchi via Gdb-patches
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi via Gdb-patches @ 2022-07-28 14:30 UTC (permalink / raw)
To: yaowenbin, gdb-patches; +Cc: hewenliang (C), linfeilong
On 7/28/22 05:22, yaowenbin via Gdb-patches wrote:
> Signed-off-by: yaowenbin<yaowenbin1@huawei.com>
> ---
> gdb/gdb_mbuild.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/gdb_mbuild.sh b/gdb/gdb_mbuild.sh
> index 47403a7..51d2853 100755
> --- a/gdb/gdb_mbuild.sh
> +++ b/gdb/gdb_mbuild.sh
> @@ -171,7 +171,7 @@ fail ()
> if test "${keepgoing}" != ""
> then
> #exit 1
> - continue
> + return 1
> else
> kill $$
> exit 1
> --
> 2.23.0
Thanks, that seems quite obvious to me. I pushed the patch with the commit
message amended to put the shellcheck error message.
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-28 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 9:22 [PATCH] use return instead of continue to avoid shellcheck error yaowenbin via Gdb-patches
2022-07-28 14:30 ` Simon Marchi via Gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox