From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7sUWBrid4mII+xsAWB0awg (envelope-from ) for ; Thu, 28 Jul 2022 10:31:20 -0400 Received: by simark.ca (Postfix, from userid 112) id 0964E1E9ED; Thu, 28 Jul 2022 10:31:20 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=sRrwZSGj; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC2341E9E9 for ; Thu, 28 Jul 2022 10:31:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52F5F385AE79 for ; Thu, 28 Jul 2022 14:31:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52F5F385AE79 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659018679; bh=Jbf6aibnzvzYojqzWxcOulksjl5nWLb3/UKf9wzJ2as=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sRrwZSGjqgymaWU07U1ZdPoYyp7ynNlY7oYwcG/sal09VNXlFa3t3ZCT8K6xjl26s JfhD0hKvJXakLPaJD0wCppCekBvyetmYm+14ODGuETzvd47jcTfZy8dDS+xCMH78Tm 5oeut6/dUyRNYR7SsInzibKAqpCFgaaqkDf+z3hs= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 532B13856DE8 for ; Thu, 28 Jul 2022 14:30:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 532B13856DE8 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 918191E9E9; Thu, 28 Jul 2022 10:30:57 -0400 (EDT) Message-ID: <595494b6-f56e-f354-cb2a-b9fd035f4bdb@simark.ca> Date: Thu, 28 Jul 2022 10:30:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] use return instead of continue to avoid shellcheck error Content-Language: fr To: yaowenbin , gdb-patches@sourceware.org References: <375f9654-9c01-6bd3-7134-6865f49b69eb@huawei.com> In-Reply-To: <375f9654-9c01-6bd3-7134-6865f49b69eb@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: "hewenliang \(C\)" , linfeilong@huawei.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 7/28/22 05:22, yaowenbin via Gdb-patches wrote: > Signed-off-by: yaowenbin > --- > gdb/gdb_mbuild.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/gdb_mbuild.sh b/gdb/gdb_mbuild.sh > index 47403a7..51d2853 100755 > --- a/gdb/gdb_mbuild.sh > +++ b/gdb/gdb_mbuild.sh > @@ -171,7 +171,7 @@ fail () > if test "${keepgoing}" != "" > then > #exit 1 > - continue > + return 1 > else > kill $$ > exit 1 > -- > 2.23.0 Thanks, that seems quite obvious to me. I pushed the patch with the commit message amended to put the shellcheck error message. Simon