From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: yaowenbin <yaowenbin1@huawei.com>, gdb-patches@sourceware.org
Cc: "hewenliang \(C\)" <hewenliang4@huawei.com>, linfeilong@huawei.com
Subject: Re: [PATCH] use return instead of continue to avoid shellcheck error
Date: Thu, 28 Jul 2022 10:30:57 -0400 [thread overview]
Message-ID: <595494b6-f56e-f354-cb2a-b9fd035f4bdb@simark.ca> (raw)
In-Reply-To: <375f9654-9c01-6bd3-7134-6865f49b69eb@huawei.com>
On 7/28/22 05:22, yaowenbin via Gdb-patches wrote:
> Signed-off-by: yaowenbin<yaowenbin1@huawei.com>
> ---
> gdb/gdb_mbuild.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/gdb_mbuild.sh b/gdb/gdb_mbuild.sh
> index 47403a7..51d2853 100755
> --- a/gdb/gdb_mbuild.sh
> +++ b/gdb/gdb_mbuild.sh
> @@ -171,7 +171,7 @@ fail ()
> if test "${keepgoing}" != ""
> then
> #exit 1
> - continue
> + return 1
> else
> kill $$
> exit 1
> --
> 2.23.0
Thanks, that seems quite obvious to me. I pushed the patch with the commit
message amended to put the shellcheck error message.
Simon
prev parent reply other threads:[~2022-07-28 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 9:22 yaowenbin via Gdb-patches
2022-07-28 14:30 ` Simon Marchi via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595494b6-f56e-f354-cb2a-b9fd035f4bdb@simark.ca \
--to=gdb-patches@sourceware.org \
--cc=hewenliang4@huawei.com \
--cc=linfeilong@huawei.com \
--cc=simark@simark.ca \
--cc=yaowenbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox