Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>,
	       Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: Re: [PATCH 2/2] Involve gdbarch in taking DWARF register pieces
Date: Fri, 15 Apr 2016 18:37:00 -0000	[thread overview]
Message-ID: <571134CD.8080507@redhat.com> (raw)
In-Reply-To: <20160415180943.4FEE857EE@oc7340732750.ibm.com>

Could we have some comment somewhere on what a "part" is?

This comment isn't very enlightening, IMHO:

+# Locate a part of size LEN within register *REGNUM, possibly overwriting
+# *REGNUM.  Return the offset of the part within the (possibly adjusted)
+# register.
+m:int:register_part:int len, int *regnum:len, regnum::default_register_part::0

Reading this in isolation I have no idea what it's for.  I skimmed the patch
and didn't find any.  Sorry if it's there and I missed it.

Thanks,
Pedro Alves


  reply	other threads:[~2016-04-15 18:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 10:42 [PATCH 0/2] Fixes for some s390 fails with store.exp Andreas Arnez
2016-04-15 10:43 ` [PATCH 1/2] S390: Take value from sub-register if applicable Andreas Arnez
2016-04-15 18:08   ` Ulrich Weigand
2016-04-15 10:43 ` [PATCH 2/2] Involve gdbarch in taking DWARF register pieces Andreas Arnez
2016-04-15 18:10   ` Ulrich Weigand
2016-04-15 18:37     ` Pedro Alves [this message]
2016-04-18 11:53       ` Andreas Arnez
2016-04-18 13:53         ` Pedro Alves
2016-04-18 15:02           ` Andreas Arnez
2016-04-18 15:55             ` Pedro Alves
2016-04-18 15:57               ` Doug Evans
2016-04-19 12:08               ` Andreas Arnez
2016-04-28 13:24                 ` [PING][PATCH " Andreas Arnez
2016-04-28 14:47                   ` Pedro Alves
2016-04-28 16:51                     ` Andreas Arnez
2016-04-28 18:16                       ` Andreas Arnez
2016-04-28 22:15                         ` Pedro Alves
2016-04-28 22:15                       ` Pedro Alves
2016-06-14 17:03                   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571134CD.8080507@redhat.com \
    --to=palves@redhat.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox