From: Pedro Alves <palves@redhat.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>,
Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PING][PATCH 2/2] Involve gdbarch in taking DWARF register pieces
Date: Thu, 28 Apr 2016 14:47:00 -0000 [thread overview]
Message-ID: <ee0690e4-1228-7479-61cb-82366f643801@redhat.com> (raw)
In-Reply-To: <m3h9elvpc7.fsf_-_@oc1027705133.ibm.com>
On 04/28/2016 02:24 PM, Andreas Arnez wrote:
> Ping:
>
> https://sourceware.org/ml/gdb-patches/2016-04/msg00437.html
>
> IIRC, there was some uncertainty about the clarity/meaning of the new
> gdbarch method's description below. Or has this cleared up by now?
Sorry, I've spent the last hour trying to wrap my head around this,
but I'm still confused. :-/ I'm sorry to be blocking this.
>
> On Tue, Apr 19 2016, Andreas Arnez wrote:
>
>> Here's another attempt:
>>
>> Determine the physical placement of a piece of size LEN within register
>> *REGNUM, possibly overwriting *REGNUM. (E.g., some ABIs have unwindable
>> sub-registers embedded in non-unwindable full registers, and this method
>> diverts from the full register to the sub-register if possible.)
I couldn't find any reference to "sub-register" in the codebase.
I'd assume it's something like "eax" being a sub part of "rax"
on x86-64. But I'm not certain that's the case here? On a machine with
vector registers, is a FP register really a chunk of the vector
register, or is it a real separate physical register?
My main confusion revolves I think, around how these points
are addressed:
- FP registers and vector registers have the same identical
DWARF register number.
- If the object stored is <= 8 bytes, we should find it in
the FP register; otherwise get it from the vector register.
I'd naively think that the fix for something like that would be
to make dwarf_reg_to_regnum return the gdb FP register number instead
of the vector number, when the type fits in a FP register, instead of
the need for an extra diversion step. Ignoring the fact that we don't
currently pass the type/size to gdbarch_dwarf_reg_to_regnum.
It may be that the end result is the same, but it's all blurry to
me still.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-04-28 14:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 10:42 [PATCH 0/2] Fixes for some s390 fails with store.exp Andreas Arnez
2016-04-15 10:43 ` [PATCH 2/2] Involve gdbarch in taking DWARF register pieces Andreas Arnez
2016-04-15 18:10 ` Ulrich Weigand
2016-04-15 18:37 ` Pedro Alves
2016-04-18 11:53 ` Andreas Arnez
2016-04-18 13:53 ` Pedro Alves
2016-04-18 15:02 ` Andreas Arnez
2016-04-18 15:55 ` Pedro Alves
2016-04-18 15:57 ` Doug Evans
2016-04-19 12:08 ` Andreas Arnez
2016-04-28 13:24 ` [PING][PATCH " Andreas Arnez
2016-04-28 14:47 ` Pedro Alves [this message]
2016-04-28 16:51 ` Andreas Arnez
2016-04-28 18:16 ` Andreas Arnez
2016-04-28 22:15 ` Pedro Alves
2016-04-28 22:15 ` Pedro Alves
2016-06-14 17:03 ` Jan Kratochvil
2016-04-15 10:43 ` [PATCH 1/2] S390: Take value from sub-register if applicable Andreas Arnez
2016-04-15 18:08 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee0690e4-1228-7479-61cb-82366f643801@redhat.com \
--to=palves@redhat.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox