Re: [PATCH 2/2] Involve gdbarch in taking DWARF register pieces

[Andreas Arnez <arnez@linux.vnet.ibm.com>]

On Fri, Apr 15 2016, Pedro Alves wrote:

> Could we have some comment somewhere on what a "part" is?
>
> This comment isn't very enlightening, IMHO:
>
> +# Locate a part of size LEN within register *REGNUM, possibly overwriting
> +# *REGNUM.  Return the offset of the part within the (possibly adjusted)
> +# register.
> +m:int:register_part:int len, int *regnum:len, regnum::default_register_part::0
>
> Reading this in isolation I have no idea what it's for.  I skimmed the patch
> and didn't find any.  Sorry if it's there and I missed it.

Hm, I used the word "part" to imply a slightly more general meaning than
the DWARF term "piece".  But that may actually be counterproductive...
So how about renaming the method to "register_piece" and then adjusting
the comment like this:

  Determine the placement of a DWARF piece (DW_OP_piece) of size LEN
  within register *REGNUM, possibly overwriting *REGNUM.  Return the
  offset of the piece within the (possibly adjusted) register.  This
  method also applies when interpreting a register as a LEN-sized type.

Does this help?

--
Andreas