From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90639 invoked by alias); 15 Apr 2016 18:37:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89436 invoked by uid 89); 15 Apr 2016 18:37:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HTo:U*uweigand X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 15 Apr 2016 18:37:04 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79C8081110; Fri, 15 Apr 2016 18:37:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3FIb1QP003696; Fri, 15 Apr 2016 14:37:02 -0400 Subject: Re: [PATCH 2/2] Involve gdbarch in taking DWARF register pieces To: Ulrich Weigand , Andreas Arnez References: <20160415180943.4FEE857EE@oc7340732750.ibm.com> Cc: gdb-patches@sourceware.org, Ulrich Weigand From: Pedro Alves Message-ID: <571134CD.8080507@redhat.com> Date: Fri, 15 Apr 2016 18:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160415180943.4FEE857EE@oc7340732750.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00364.txt.bz2 Could we have some comment somewhere on what a "part" is? This comment isn't very enlightening, IMHO: +# Locate a part of size LEN within register *REGNUM, possibly overwriting +# *REGNUM. Return the offset of the part within the (possibly adjusted) +# register. +m:int:register_part:int len, int *regnum:len, regnum::default_register_part::0 Reading this in isolation I have no idea what it's for. I skimmed the patch and didn't find any. Sorry if it's there and I missed it. Thanks, Pedro Alves