From: Pedro Alves <palves@redhat.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] [D] Remove search_parents parameter from d_lookup_symbol_imports
Date: Mon, 19 Oct 2015 15:42:00 -0000 [thread overview]
Message-ID: <56250F4F.7050908@redhat.com> (raw)
In-Reply-To: <CABOHX+dAvESSm0gHL4vvwX4JuoZhiy+uac6hSirQ6c35Da0_SQ@mail.gmail.com>
On 10/11/2015 01:01 PM, Iain Buclaw wrote:
> Whilst looking at part one, a moment of insight came to me and I
> realized this code is completely nonsensical.
>
> For a start, when importing modules, you don't gain access to all
> parent packages of the given module.
>
> To add some confusion, even the comment was wrong. It doesn't even
> cater for the example given (it's d_lookup_symbol_module that walks up
> each block scope).
>
> I feel embarrassed it didn't come to me before. :-)
The usual penance is writing test cases. :-)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-10-19 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 12:01 Iain Buclaw
2015-10-19 15:42 ` Pedro Alves [this message]
2015-10-25 11:19 ` Iain Buclaw
2015-10-26 3:47 ` Doug Evans
2015-10-29 17:10 ` Iain Buclaw
2016-01-30 13:50 ` Iain Buclaw
2015-10-26 21:35 ` Pedro Alves
2015-10-29 17:10 ` Iain Buclaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56250F4F.7050908@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ibuclaw@gdcproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox