Re: [PATCH 2/2] [D] Remove search_parents parameter from d_lookup_symbol_imports

[Iain Buclaw <ibuclaw@gdcproject.org>]

On 19 October 2015 at 17:42, Pedro Alves <palves@redhat.com> wrote:
>
> On 10/11/2015 01:01 PM, Iain Buclaw wrote:
> > Whilst looking at part one, a moment of insight came to me and I
> > realized this code is completely nonsensical.
> >
> > For a start, when importing modules, you don't gain access to all
> > parent packages of the given module.
> >
> > To add some confusion, even the comment was wrong.  It doesn't even
> > cater for the example given (it's d_lookup_symbol_module that walks up
> > each block scope).
> >
> > I feel embarrassed it didn't come to me before. :-)
>
> The usual penance is writing test cases.  :-)
>

It helps if there is a compiler readily available to compile said
tests.  However, there likely is a way to get around this that I'm not
aware of. (Skip certain tests if a compiler doesn't exist?  ;-)

With this patch though, it's all dead code.  Hard to write a test for
something that is unreachable.

Regards
Iain