From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108791 invoked by alias); 19 Oct 2015 15:42:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108777 invoked by uid 89); 19 Oct 2015 15:42:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 19 Oct 2015 15:42:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9967B2CAB7D; Mon, 19 Oct 2015 15:42:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9JFg8Fb009275; Mon, 19 Oct 2015 11:42:08 -0400 Message-ID: <56250F4F.7050908@redhat.com> Date: Mon, 19 Oct 2015 15:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Iain Buclaw , GDB Patches Subject: Re: [PATCH 2/2] [D] Remove search_parents parameter from d_lookup_symbol_imports References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00341.txt.bz2 On 10/11/2015 01:01 PM, Iain Buclaw wrote: > Whilst looking at part one, a moment of insight came to me and I > realized this code is completely nonsensical. > > For a start, when importing modules, you don't gain access to all > parent packages of the given module. > > To add some confusion, even the comment was wrong. It doesn't even > cater for the example given (it's d_lookup_symbol_module that walks up > each block scope). > > I feel embarrassed it didn't come to me before. :-) The usual penance is writing test cases. :-) Thanks, Pedro Alves