From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame'.
Date: Wed, 30 Sep 2015 14:00:00 -0000 [thread overview]
Message-ID: <560BEB00.8020308@redhat.com> (raw)
In-Reply-To: <2d36cf742ecb05db45a18f5025f42ad58d780fa8.1441996064.git.andrew.burgess@embecosm.com>
On 09/11/2015 07:49 PM, Andrew Burgess wrote:
> --- a/gdb/stack.c
> +++ b/gdb/stack.c
> @@ -100,6 +100,9 @@ static void set_last_displayed_sal (int valid,
> struct symtab *symtab,
> int line);
>
> +static struct frame_info * find_frame_for_function (char *);
> +static struct frame_info * find_frame_for_address (CORE_ADDR);
No space after first *. Also, can that be "const char *" ?
But most importantly - is there a reason this is implemented
the way it is (manually handling completion, parsing, etc.) instead of
creating sub-commands for "frame", etc., like done e.g., for "thread",
thread apply", "thread apply all", etc. ?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-09-30 14:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 18:49 [PATCH 0/9] Changes to frame selection Andrew Burgess
2015-09-11 18:49 ` [PATCH 2/9] gdb: Select a frame for frame_info Andrew Burgess
2015-09-11 18:50 ` [PATCH 6/9] gdb: Avoid unneeded calls to parse_frame_specification Andrew Burgess
2015-09-30 13:48 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 7/9] gdb: Simplify parse_frame_specification Andrew Burgess
2015-09-30 13:50 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame' Andrew Burgess
2015-09-11 20:21 ` Eli Zaretskii
2015-09-15 10:41 ` Andrew Burgess
2015-09-15 10:50 ` Eli Zaretskii
2015-09-17 11:36 ` Andrew Burgess
2015-09-30 14:00 ` Pedro Alves [this message]
2015-09-11 18:50 ` [PATCH 4/9] gdb/doc: Restructure frame command documentation Andrew Burgess
2015-09-11 20:17 ` Eli Zaretskii
2015-09-11 18:50 ` [PATCH 8/9] gdb: Split func_command into two parts Andrew Burgess
2015-09-30 13:52 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 3/9] gdb: Make use of safe-ctype.h header Andrew Burgess
2015-09-30 13:43 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 1/9] gdb: Check the selected-frame in frame_find_by_id Andrew Burgess
2015-09-30 13:40 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 5/9] gdb: Fix bug with dbx style func command Andrew Burgess
2015-09-30 13:47 ` Pedro Alves
2015-10-26 13:40 ` Thomas Preud'homme
2015-10-26 16:33 ` Andrew Burgess
2015-10-12 21:43 ` [PATCH 0/9] Changes to frame selection Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560BEB00.8020308@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox