From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH 3/9] gdb: Make use of safe-ctype.h header.
Date: Fri, 11 Sep 2015 18:50:00 -0000 [thread overview]
Message-ID: <208a01e3f21d7c7e2662a1d2199c4dedab668989.1441996064.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1441996064.git.andrew.burgess@embecosm.com>
In-Reply-To: <cover.1441996064.git.andrew.burgess@embecosm.com>
In stack.c switch to using safe-ctype.h instead of ctype.h, update code
as required.
gdb/ChangeLog:
* stack.c: Include safe-ctype.h not ctype.h.
(parse_frame_specification): Use ISSPACE not isspace.
(backtrace_command): Use TOLOWER not tolower.
---
gdb/ChangeLog | 6 ++++++
gdb/stack.c | 6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 79952c7..50aa7f0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2015-09-11 Andrew Burgess <andrew.burgess@embecosm.com>
+ * stack.c: Include safe-ctype.h not ctype.h.
+ (parse_frame_specification): Use ISSPACE not isspace.
+ (backtrace_command): Use TOLOWER not tolower.
+
+2015-09-11 Andrew Burgess <andrew.burgess@embecosm.com>
+
* frame.h (make_restore_selected_frame_cleanup): Declare new
function.
* frame.c (do_restore_selected_frame): New function.
diff --git a/gdb/stack.c b/gdb/stack.c
index 82b366d..2fe176f 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -48,7 +48,7 @@
#include "cli/cli-utils.h"
#include "objfiles.h"
-#include <ctype.h>
+#include "safe-ctype.h"
#include "symfile.h"
#include "extension.h"
@@ -1305,7 +1305,7 @@ parse_frame_specification_1 (const char *frame_exp, const char *message,
/* Parse the argument, extract it, save it. */
for (p = frame_exp;
- *p && !isspace (*p);
+ *p && !ISSPACE (*p);
p++);
addr_string = savestring (frame_exp, p - frame_exp);
frame_exp = p;
@@ -1904,7 +1904,7 @@ backtrace_command (char *arg, int from_tty)
unsigned int j;
for (j = 0; j < strlen (argv[i]); j++)
- argv[i][j] = tolower (argv[i][j]);
+ argv[i][j] = TOLOWER (argv[i][j]);
if (no_filters < 0 && subset_compare (argv[i], "no-filters"))
no_filters = argc;
--
2.5.1
next prev parent reply other threads:[~2015-09-11 18:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 18:49 [PATCH 0/9] Changes to frame selection Andrew Burgess
2015-09-11 18:49 ` [PATCH 2/9] gdb: Select a frame for frame_info Andrew Burgess
2015-09-11 18:50 ` [PATCH 1/9] gdb: Check the selected-frame in frame_find_by_id Andrew Burgess
2015-09-30 13:40 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 5/9] gdb: Fix bug with dbx style func command Andrew Burgess
2015-09-30 13:47 ` Pedro Alves
2015-10-26 13:40 ` Thomas Preud'homme
2015-10-26 16:33 ` Andrew Burgess
2015-09-11 18:50 ` Andrew Burgess [this message]
2015-09-30 13:43 ` [PATCH 3/9] gdb: Make use of safe-ctype.h header Pedro Alves
2015-09-11 18:50 ` [PATCH 8/9] gdb: Split func_command into two parts Andrew Burgess
2015-09-30 13:52 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 4/9] gdb/doc: Restructure frame command documentation Andrew Burgess
2015-09-11 20:17 ` Eli Zaretskii
2015-09-11 18:50 ` [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame' Andrew Burgess
2015-09-11 20:21 ` Eli Zaretskii
2015-09-15 10:41 ` Andrew Burgess
2015-09-15 10:50 ` Eli Zaretskii
2015-09-17 11:36 ` Andrew Burgess
2015-09-30 14:00 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 7/9] gdb: Simplify parse_frame_specification Andrew Burgess
2015-09-30 13:50 ` Pedro Alves
2015-09-11 18:50 ` [PATCH 6/9] gdb: Avoid unneeded calls to parse_frame_specification Andrew Burgess
2015-09-30 13:48 ` Pedro Alves
2015-10-12 21:43 ` [PATCH 0/9] Changes to frame selection Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=208a01e3f21d7c7e2662a1d2199c4dedab668989.1441996064.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox