Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Thomas Preud'homme <thomas.preudhomme@arm.com>
Cc: 'Pedro Alves' <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 5/9] gdb: Fix bug with dbx style func command.
Date: Mon, 26 Oct 2015 16:33:00 -0000	[thread overview]
Message-ID: <20151026134007.GD23628@embecosm.com> (raw)
In-Reply-To: <003301d10fda$6e7f2ad0$4b7d8070$@arm.com>

* Thomas Preud'homme <thomas.preudhomme@arm.com> [2015-10-26 18:38:17 +0800]:

> > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] On Behalf Of Pedro Alves
> > Sent: Wednesday, September 30, 2015 9:47 PM
> > 
> > On 09/11/2015 07:49 PM, Andrew Burgess wrote:
> > > The func command, available when starting gdb in dbx mode, is
> > supposed
> > > to take a function name and locate the frame for that function in the
> > > stack.  This has been broken for a while due to an invalid check of the
> > > arguments within the worker function.  Fixed in this commit.
> > 
> > I wonder whether anyone uses / cares about the dbx mode...
> > 
> > >
> > > gdb/ChangeLog:
> > >
> > > 	* stack.c (func_command): Return early when there is no ARG
> > > 	string.
> > >
> > > gdb/testsuite/ChangeLog:
> > >
> > > 	* gdb.base/dbx.exp (test_func): Remove xfails, update
> > expected
> > > 	results.
> > 
> > OK.
> 
> Actually dbx style func still fails on ARM so this changes shows up
> as a regression (XFAIL- > FAIL). See [1] for a bit more details.

The failure you're seeing on ARM, where gdb says "Target is
executing." seems pretty strange, and certainly isn't the failure that
I would have expected before, this looks like a different issue, which
is probably worth some investigation.  I'm guessing here, but I doubt
that the original XFAIL I removed was intended to mask this specific
failure.

It would probably help to diagnose this issue if you could attach a
gdb.log for a test run of dbx.exp.

Thanks,
Andrew


  reply	other threads:[~2015-10-26 13:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 18:49 [PATCH 0/9] Changes to frame selection Andrew Burgess
2015-09-11 18:49 ` [PATCH 2/9] gdb: Select a frame for frame_info Andrew Burgess
2015-09-11 18:50 ` [PATCH 7/9] gdb: Simplify parse_frame_specification Andrew Burgess
2015-09-30 13:50   ` Pedro Alves
2015-09-11 18:50 ` [PATCH 6/9] gdb: Avoid unneeded calls to parse_frame_specification Andrew Burgess
2015-09-30 13:48   ` Pedro Alves
2015-09-11 18:50 ` [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame' Andrew Burgess
2015-09-11 20:21   ` Eli Zaretskii
2015-09-15 10:41     ` Andrew Burgess
2015-09-15 10:50       ` Eli Zaretskii
2015-09-17 11:36         ` Andrew Burgess
2015-09-30 14:00   ` Pedro Alves
2015-09-11 18:50 ` [PATCH 4/9] gdb/doc: Restructure frame command documentation Andrew Burgess
2015-09-11 20:17   ` Eli Zaretskii
2015-09-11 18:50 ` [PATCH 8/9] gdb: Split func_command into two parts Andrew Burgess
2015-09-30 13:52   ` Pedro Alves
2015-09-11 18:50 ` [PATCH 3/9] gdb: Make use of safe-ctype.h header Andrew Burgess
2015-09-30 13:43   ` Pedro Alves
2015-09-11 18:50 ` [PATCH 1/9] gdb: Check the selected-frame in frame_find_by_id Andrew Burgess
2015-09-30 13:40   ` Pedro Alves
2015-09-11 18:50 ` [PATCH 5/9] gdb: Fix bug with dbx style func command Andrew Burgess
2015-09-30 13:47   ` Pedro Alves
2015-10-26 13:40     ` Thomas Preud'homme
2015-10-26 16:33       ` Andrew Burgess [this message]
2015-10-12 21:43 ` [PATCH 0/9] Changes to frame selection Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151026134007.GD23628@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=thomas.preudhomme@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox