From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66047 invoked by alias); 26 Oct 2015 13:40:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66037 invoked by uid 89); 26 Oct 2015 13:40:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wi0-f171.google.com Received: from mail-wi0-f171.google.com (HELO mail-wi0-f171.google.com) (209.85.212.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 26 Oct 2015 13:40:13 +0000 Received: by wicfv8 with SMTP id fv8so116592160wic.0 for ; Mon, 26 Oct 2015 06:40:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=osd+a/+U5lmY7+mViFuMC02BouM3vaJk8B21ISkuyTs=; b=O6zrzVId854ncFFAY53gkBjJK+GELSHX4F5LxfCf2dYgVidj+hwrP+3RnEctkw8XHH Fjv357OOi+1qibP6zWEFc13sNGh3iV0F27bDrS1HUafnNwO77XDYjizjFu3SXkhJYpQW vSodmfjAVWig5jrl2wwHdX/+ruTG5Z+IIna2i8zSCWfrmBr75Y+fFeC/dFszBQEUnpLy CC+97MCdwzY/Ky3eC7w8ILSyTYl2ZYJ2gCWYwClDGevv7HeEKXeFGKGW37XLpwgwHurS oHFcsgttu7xTKS1rUF/COEny27sXYIqYV1wNcpFmSCOQtfkX0hm6B6LRveuimZ54rrqU aRLw== X-Gm-Message-State: ALoCoQlPGDl5rbPo9qizq4/XupExdOdZoDeJI3135rq2XC+7UhEYOTG52aYKl3tKuW26CzK0KO/j X-Received: by 10.194.82.166 with SMTP id j6mr22266101wjy.63.1445866810279; Mon, 26 Oct 2015 06:40:10 -0700 (PDT) Received: from localhost (host81-131-206-221.range81-131.btcentralplus.com. [81.131.206.221]) by smtp.gmail.com with ESMTPSA id ft3sm13986936wic.7.2015.10.26.06.40.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2015 06:40:09 -0700 (PDT) Date: Mon, 26 Oct 2015 16:33:00 -0000 From: Andrew Burgess To: Thomas Preud'homme Cc: 'Pedro Alves' , gdb-patches@sourceware.org Subject: Re: [PATCH 5/9] gdb: Fix bug with dbx style func command. Message-ID: <20151026134007.GD23628@embecosm.com> References: <8629fd6198d107d87d4db9b3eec45774bfaae2b6.1441996064.git.andrew.burgess@embecosm.com> <560BE7EE.2090401@redhat.com> <003301d10fda$6e7f2ad0$4b7d8070$@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <003301d10fda$6e7f2ad0$4b7d8070$@arm.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00564.txt.bz2 * Thomas Preud'homme [2015-10-26 18:38:17 +0800]: > > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > owner@sourceware.org] On Behalf Of Pedro Alves > > Sent: Wednesday, September 30, 2015 9:47 PM > > > > On 09/11/2015 07:49 PM, Andrew Burgess wrote: > > > The func command, available when starting gdb in dbx mode, is > > supposed > > > to take a function name and locate the frame for that function in the > > > stack. This has been broken for a while due to an invalid check of the > > > arguments within the worker function. Fixed in this commit. > > > > I wonder whether anyone uses / cares about the dbx mode... > > > > > > > > gdb/ChangeLog: > > > > > > * stack.c (func_command): Return early when there is no ARG > > > string. > > > > > > gdb/testsuite/ChangeLog: > > > > > > * gdb.base/dbx.exp (test_func): Remove xfails, update > > expected > > > results. > > > > OK. > > Actually dbx style func still fails on ARM so this changes shows up > as a regression (XFAIL- > FAIL). See [1] for a bit more details. The failure you're seeing on ARM, where gdb says "Target is executing." seems pretty strange, and certainly isn't the failure that I would have expected before, this looks like a different issue, which is probably worth some investigation. I'm guessing here, but I doubt that the original XFAIL I removed was intended to mask this specific failure. It would probably help to diagnose this issue if you could attach a gdb.log for a test run of dbx.exp. Thanks, Andrew