From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28788 invoked by alias); 30 Sep 2015 14:00:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28777 invoked by uid 89); 30 Sep 2015 14:00:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Sep 2015 14:00:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 2F96F91E90; Wed, 30 Sep 2015 14:00:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8UE0Wv9031358; Wed, 30 Sep 2015 10:00:33 -0400 Message-ID: <560BEB00.8020308@redhat.com> Date: Wed, 30 Sep 2015 14:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame'. References: <2d36cf742ecb05db45a18f5025f42ad58d780fa8.1441996064.git.andrew.burgess@embecosm.com> In-Reply-To: <2d36cf742ecb05db45a18f5025f42ad58d780fa8.1441996064.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00664.txt.bz2 On 09/11/2015 07:49 PM, Andrew Burgess wrote: > --- a/gdb/stack.c > +++ b/gdb/stack.c > @@ -100,6 +100,9 @@ static void set_last_displayed_sal (int valid, > struct symtab *symtab, > int line); > > +static struct frame_info * find_frame_for_function (char *); > +static struct frame_info * find_frame_for_address (CORE_ADDR); No space after first *. Also, can that be "const char *" ? But most importantly - is there a reason this is implemented the way it is (manually handling completion, parsing, etc.) instead of creating sub-commands for "frame", etc., like done e.g., for "thread", thread apply", "thread apply all", etc. ? Thanks, Pedro Alves