From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [gdb/testsuite] Reformat gdb.ada using tclfmt
Date: Tue, 31 Mar 2026 08:49:06 +0200 [thread overview]
Message-ID: <55fe735c-ed0f-4efe-a7b1-81c6ac52528c@suse.de> (raw)
In-Reply-To: <20260325161319.4092668-3-tdevries@suse.de>
On 3/25/26 5:13 PM, Tom de Vries wrote:
> [1]https://github.com/nmoroze/tclint/issues/160
> [2]https://github.com/nmoroze/tclint/issues/140
These two issues have been fixed upstream.
> Likewise in:
> - gdb.ada/data-sections.exp
This file contains:
...
if {[gdb_compile_ada "${srcfile}" "${binfile}" executable \
{debug additional_flags=-fdata-sections
ldflags=-Wl,--gc-sections}] \
!= ""} {
return
}
...
Now that issue #140 has been fixed, tclfmt rewrites this to:
...
if {[gdb_compile_ada "${srcfile}" "${binfile}" executable \
{debug additional_flags=-fdata-sections
ldflags=-Wl,--gc-sections}]
!= ""} {
return
}
...
in other words, dropping the backslash at the end of the line.
The resulting formatting is also emacs-stable, that is, emacs
auto-indent doesn't change it, but IWBN if tclfmt kept the same
formatting.
I've filed an issue about it ( https://github.com/nmoroze/tclint/
issues/162 ).
Thanks,
- Tom
next prev parent reply other threads:[~2026-03-31 6:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:13 [PATCH 0/2] " Tom de Vries
2026-03-25 16:13 ` [PATCH 1/2] [gdb] Update tclint.style in pyproject.toml Tom de Vries
2026-03-25 16:13 ` [PATCH 2/2] [gdb/testsuite] Reformat gdb.ada using tclfmt Tom de Vries
2026-03-25 16:42 ` Tom de Vries
2026-03-31 6:49 ` Tom de Vries [this message]
2026-04-10 12:35 ` [PING][PATCH 0/2] " Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55fe735c-ed0f-4efe-a7b1-81c6ac52528c@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox