Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [gdb/testsuite] Reformat gdb.ada using tclfmt
Date: Wed, 25 Mar 2026 17:42:40 +0100	[thread overview]
Message-ID: <4ebdf5d8-2933-4f62-8cd2-e352f8af009d@suse.de> (raw)
In-Reply-To: <20260325161319.4092668-3-tdevries@suse.de>

On 3/25/26 5:13 PM, Tom de Vries wrote:
> diff --git a/gdb/testsuite/gdb.ada/info_auto_lang.exp b/gdb/testsuite/gdb.ada/info_auto_lang.exp
> index e717802a8d2..8f833159aff 100644
> --- a/gdb/testsuite/gdb.ada/info_auto_lang.exp
> +++ b/gdb/testsuite/gdb.ada/info_auto_lang.exp
> @@ -37,7 +37,7 @@ if { [gdb_compile "${csrcfile}" "${cobject}" object [list debug]] != "" } {
>       untested "failed to compile"
>       return
>   }
> -if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug]] != "" } {
> +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug]] != ""} {
>       untested "failed to compile"
>       return
>   }
> @@ -49,8 +49,8 @@ if {![runto "some_c.c:$bp_location"]} {
>       return
>   }
>   
> -set func_in_c(c_syntax)      "${decimal}:	void proc_in_c\\\(void\\\);"
> -set func_in_c(ada_syntax)    "${decimal}:	procedure proc_in_c;"
> +set func_in_c(c_syntax) "${decimal}:	void proc_in_c\\\(void\\\);"
> +set func_in_c(ada_syntax) "${decimal}:	procedure proc_in_c;"
I had an AI review this patch, and it pointed to this file, noting that 
this type of change "slightly reduces vertical alignment readability".

Thanks,
- Tom


  reply	other threads:[~2026-03-25 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 16:13 [PATCH 0/2] " Tom de Vries
2026-03-25 16:13 ` [PATCH 1/2] [gdb] Update tclint.style in pyproject.toml Tom de Vries
2026-03-25 16:13 ` [PATCH 2/2] [gdb/testsuite] Reformat gdb.ada using tclfmt Tom de Vries
2026-03-25 16:42   ` Tom de Vries [this message]
2026-03-31  6:49   ` Tom de Vries
2026-04-10 12:35 ` [PING][PATCH 0/2] " Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ebdf5d8-2933-4f62-8cd2-e352f8af009d@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox