From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PING][PATCH 0/2] [gdb/testsuite] Reformat gdb.ada using tclfmt
Date: Fri, 10 Apr 2026 14:35:57 +0200 [thread overview]
Message-ID: <a98ef818-0d3d-4d65-b70c-8a226f1a1009@suse.de> (raw)
In-Reply-To: <20260325161319.4092668-1-tdevries@suse.de>
On 3/25/26 5:13 PM, Tom de Vries wrote:
> I'd like to get to a situation where we use tclfmt as pre-commit formatter for
> the testsuite, in the same way that we use say black and isort for python
> files [1].
>
> Of course that doesn't work if the changes are too intrusive, so I've been
> working to get tclfmt to format in a style compatible with the gdb testsuite.
>
> My test subject for this effort has been the gdb.ada directory.
>
> With tcl 0.8.0, most issues are fixed, so this series:
> - updates tclint.style in gdb/pyproject.toml to be less intrusive, and
> - applies tclfmt to gdb.ada (manually reverting some changes that still need
> fixing in tclfmt).
>
Ping.
Thanks,
- Tom
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=33724
>
> Tom de Vries (2):
> [gdb] Update tclint.style in pyproject.toml
> [gdb/testsuite] Reformat gdb.ada using tclfmt
>
> gdb/pyproject.toml | 5 +++-
> gdb/testsuite/gdb.ada/access_tagged_param.exp | 2 +-
> .../gdb.ada/access_to_packed_array.exp | 2 +-
> gdb/testsuite/gdb.ada/addr_arith.exp | 2 +-
> gdb/testsuite/gdb.ada/arr_arr.exp | 2 +-
> gdb/testsuite/gdb.ada/array_bounds.exp | 2 +-
> .../gdb.ada/array_subscript_addr.exp | 2 +-
> gdb/testsuite/gdb.ada/arraydim.exp | 2 +-
> gdb/testsuite/gdb.ada/assign_1.exp | 1 -
> gdb/testsuite/gdb.ada/assign_arr.exp | 2 +-
> gdb/testsuite/gdb.ada/atomic_enum.exp | 2 +-
> .../gdb.ada/attr_ref_and_charlit.exp | 2 +-
> gdb/testsuite/gdb.ada/bad-task-bp-keyword.exp | 2 +-
> gdb/testsuite/gdb.ada/bp_c_mixed_case.exp | 2 +-
> gdb/testsuite/gdb.ada/bp_enum_homonym.exp | 2 +-
> gdb/testsuite/gdb.ada/bp_inlined_func.exp | 2 +-
> gdb/testsuite/gdb.ada/bp_on_var.exp | 3 +--
> gdb/testsuite/gdb.ada/bp_range_type.exp | 2 +-
> gdb/testsuite/gdb.ada/bp_reset.exp | 2 +-
> gdb/testsuite/gdb.ada/call_pn.exp | 2 +-
> gdb/testsuite/gdb.ada/catch_assert_if.exp | 2 +-
> gdb/testsuite/gdb.ada/catch_ex.exp | 2 +-
> gdb/testsuite/gdb.ada/char_enum.exp | 2 +-
> gdb/testsuite/gdb.ada/char_enum_overload.exp | 2 +-
> gdb/testsuite/gdb.ada/char_enum_unicode.exp | 2 +-
> gdb/testsuite/gdb.ada/char_param.exp | 8 +++---
> gdb/testsuite/gdb.ada/complete.exp | 16 ++++++------
> gdb/testsuite/gdb.ada/cond_lang.exp | 2 +-
> gdb/testsuite/gdb.ada/convvar_comp.exp | 2 +-
> gdb/testsuite/gdb.ada/delta-assign.exp | 2 +-
> gdb/testsuite/gdb.ada/disc_arr_bound.exp | 2 +-
> gdb/testsuite/gdb.ada/dot_all.exp | 2 +-
> gdb/testsuite/gdb.ada/dyn_arrayidx.exp | 2 +-
> gdb/testsuite/gdb.ada/dyn_loc.exp | 2 +-
> gdb/testsuite/gdb.ada/dyn_stride.exp | 2 +-
> gdb/testsuite/gdb.ada/dynamic-iface.exp | 2 +-
> gdb/testsuite/gdb.ada/enums_overload.exp | 2 +-
> gdb/testsuite/gdb.ada/excep_handle.exp | 2 +-
> gdb/testsuite/gdb.ada/expr_delims.exp | 4 +--
> gdb/testsuite/gdb.ada/expr_with_funcall.exp | 14 +++++------
> gdb/testsuite/gdb.ada/exprs.exp | 2 +-
> gdb/testsuite/gdb.ada/fin_fun_out.exp | 2 +-
> .../gdb.ada/fixed_points_function.exp | 2 +-
> gdb/testsuite/gdb.ada/float-bits.exp | 9 +++----
> gdb/testsuite/gdb.ada/formatted_ref.exp | 4 +--
> gdb/testsuite/gdb.ada/frame_args.exp | 2 +-
> gdb/testsuite/gdb.ada/fullname_bp.exp | 2 +-
> gdb/testsuite/gdb.ada/fun_addr.exp | 2 +-
> gdb/testsuite/gdb.ada/fun_in_declare.exp | 2 +-
> gdb/testsuite/gdb.ada/fun_overload_menu.exp | 3 +--
> gdb/testsuite/gdb.ada/fun_renaming.exp | 2 +-
> gdb/testsuite/gdb.ada/funcall_char.exp | 2 +-
> gdb/testsuite/gdb.ada/funcall_param.exp | 2 +-
> gdb/testsuite/gdb.ada/funcall_ptr.exp | 2 +-
> gdb/testsuite/gdb.ada/ghost.exp | 2 +-
> gdb/testsuite/gdb.ada/homonym.exp | 3 +--
> .../gdb.ada/info_addr_mixed_case.exp | 2 +-
> gdb/testsuite/gdb.ada/info_auto_lang.exp | 25 +++++++++----------
> gdb/testsuite/gdb.ada/info_exc.exp | 4 +--
> gdb/testsuite/gdb.ada/inline-section-gc.exp | 1 -
> gdb/testsuite/gdb.ada/int_deref.exp | 2 +-
> gdb/testsuite/gdb.ada/interface.exp | 2 +-
> gdb/testsuite/gdb.ada/iterated-assign.exp | 2 +-
> gdb/testsuite/gdb.ada/iwide.exp | 2 +-
> gdb/testsuite/gdb.ada/lang_switch.exp | 2 +-
> gdb/testsuite/gdb.ada/length_cond.exp | 2 +-
> gdb/testsuite/gdb.ada/maint_with_ada.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_catch_assert.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_catch_ex.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp | 3 +--
> gdb/testsuite/gdb.ada/mi_dyn_arr.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_exc_info.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_interface.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_ref_changeable.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_task_arg.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_task_info.exp | 2 +-
> gdb/testsuite/gdb.ada/mi_var_access.exp | 2 +-
> gdb/testsuite/gdb.ada/minsyms.exp | 2 +-
> gdb/testsuite/gdb.ada/nested.exp | 2 +-
> gdb/testsuite/gdb.ada/non-ascii-latin-3.exp | 2 +-
> gdb/testsuite/gdb.ada/null_array.exp | 2 +-
> gdb/testsuite/gdb.ada/operator_bp.exp | 4 +--
> gdb/testsuite/gdb.ada/optim_drec.exp | 2 +-
> gdb/testsuite/gdb.ada/packed_array_assign.exp | 2 +-
> gdb/testsuite/gdb.ada/pp-rec-component.exp | 2 +-
> gdb/testsuite/gdb.ada/print_chars.exp | 3 +--
> gdb/testsuite/gdb.ada/print_pc.exp | 2 +-
> gdb/testsuite/gdb.ada/ptr_typedef.exp | 2 +-
> gdb/testsuite/gdb.ada/ptype_array.exp | 2 +-
> gdb/testsuite/gdb.ada/ptype_field.exp | 6 ++---
> gdb/testsuite/gdb.ada/ptype_tagged_param.exp | 2 +-
> gdb/testsuite/gdb.ada/py_range.exp | 2 +-
> gdb/testsuite/gdb.ada/rdv_wait.exp | 2 +-
> gdb/testsuite/gdb.ada/rec_comp.exp | 2 +-
> gdb/testsuite/gdb.ada/rec_return.exp | 2 +-
> gdb/testsuite/gdb.ada/ref_param.exp | 4 +--
> gdb/testsuite/gdb.ada/ref_tick_size.exp | 2 +-
> .../gdb.ada/rename_subscript_param.exp | 2 +-
> gdb/testsuite/gdb.ada/repeat_dyn.exp | 2 +-
> gdb/testsuite/gdb.ada/same_enum.exp | 4 +--
> gdb/testsuite/gdb.ada/scoped_watch.exp | 1 -
> gdb/testsuite/gdb.ada/set_wstr.exp | 2 +-
> gdb/testsuite/gdb.ada/small_reg_param.exp | 2 +-
> gdb/testsuite/gdb.ada/str_binop_equal.exp | 2 +-
> gdb/testsuite/gdb.ada/str_chars.exp | 2 +-
> gdb/testsuite/gdb.ada/str_ref_cmp.exp | 2 +-
> gdb/testsuite/gdb.ada/str_uninit.exp | 2 +-
> gdb/testsuite/gdb.ada/sub_variant.exp | 2 +-
> gdb/testsuite/gdb.ada/sym_print_name.exp | 2 +-
> gdb/testsuite/gdb.ada/taft_type.exp | 2 +-
> gdb/testsuite/gdb.ada/tagged.exp | 6 ++---
> gdb/testsuite/gdb.ada/task_bp.exp | 2 +-
> gdb/testsuite/gdb.ada/task_switch_in_core.exp | 3 +--
> gdb/testsuite/gdb.ada/tasks.exp | 2 +-
> gdb/testsuite/gdb.ada/tick_last_segv.exp | 2 +-
> .../gdb.ada/tick_length_array_enum_idx.exp | 2 +-
> gdb/testsuite/gdb.ada/type_coercion.exp | 2 +-
> .../gdb.ada/uninitialized-variable-record.exp | 2 +-
> gdb/testsuite/gdb.ada/uninitialized_vars.exp | 2 +-
> gdb/testsuite/gdb.ada/var_arr_attrs.exp | 2 +-
> gdb/testsuite/gdb.ada/var_arr_typedef.exp | 2 +-
> gdb/testsuite/gdb.ada/varsize_limit.exp | 2 +-
> gdb/testsuite/gdb.ada/voidctx.exp | 2 +-
> gdb/testsuite/gdb.ada/whatis_array_val.exp | 2 +-
> gdb/testsuite/gdb.ada/widewide.exp | 2 +-
> gdb/testsuite/gdb.ada/win_fu_syms.exp | 2 +-
> 126 files changed, 166 insertions(+), 174 deletions(-)
>
>
> base-commit: 1a10ac99959e8d28694cb47d0632552e6feb03b2
prev parent reply other threads:[~2026-04-10 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:13 [PATCH " Tom de Vries
2026-03-25 16:13 ` [PATCH 1/2] [gdb] Update tclint.style in pyproject.toml Tom de Vries
2026-03-25 16:13 ` [PATCH 2/2] [gdb/testsuite] Reformat gdb.ada using tclfmt Tom de Vries
2026-03-25 16:42 ` Tom de Vries
2026-03-31 6:49 ` Tom de Vries
2026-04-10 12:35 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a98ef818-0d3d-4d65-b70c-8a226f1a1009@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox