From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id M8hWCYFuy2m6XQAAWB0awg (envelope-from ) for ; Tue, 31 Mar 2026 02:49:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Rei23nCb; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ALbbN7oc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Rei23nCb; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ALbbN7oc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 008911E04F; Tue, 31 Mar 2026 02:49:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5AB831E04F for ; Tue, 31 Mar 2026 02:49:35 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 73F764B92095 for ; Tue, 31 Mar 2026 06:49:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73F764B92095 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Rei23nCb; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ALbbN7oc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Rei23nCb; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ALbbN7oc Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 02C074BB3B81 for ; Tue, 31 Mar 2026 06:49:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02C074BB3B81 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 02C074BB3B81 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774939748; cv=none; b=ZgF9qGIMVSZ92nRUjAzfbGKAhxySYYS1jNFQp2dztiAmRWCIkmQXztydYs9LMoM1Fpei3wjqoI0yjOOUOtRB1wTgo80F409gfhEf0nFHyrCuW2LTGtsyCiE6AA0+lJ7Pm7N+MBiwK9dVNMTxjyCEiIFpAzcNRzU2tzpzML9dAi8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774939748; c=relaxed/simple; bh=hViMjbQYXt02OJ82/Pv2igjYm89YsDpqqxgMoaEhIaY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=w4RaYY0WRfBmvV1Vn7Ev1uiQOamWjg+U3KfwJBPk1S5rmeoqAeif/MZC0UkVJIP7MHivJ5oSDQFcvoGCym51X8iPasZv8HFlFYV1EG9FPvvTW+18B5acERiGtpKZoneNX+n+0Xzm4YHeTZzO2Xtv25YcwdidmtQKbnyf9FbJmiw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 02C074BB3B81 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7B9C75BE9B for ; Tue, 31 Mar 2026 06:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774939746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FBmZqanWzzO95bjwHmnj9CTux+gNlouDU/+S5j9zoCY=; b=Rei23nCbN7eDS2cgYd9yeDoAxCDDCRxdlq/Vr+lxw7nibqIYv0Jv6aFOBZPtOKbKM3ZfxG K/G7g+12xcJs5SfXl80xUOgJsRm15tyve5wxeOxci7T9r1g9+MaErSNfLwtRAr2BJ2K45l nItovbgIkAHpPr/G99iA405sw6NFtKw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774939746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FBmZqanWzzO95bjwHmnj9CTux+gNlouDU/+S5j9zoCY=; b=ALbbN7oca+kiPjxC/WEJ9sOpQEumHk2YvlffFrETF33EgFwLA6KtjLch9tCyIKLKgfKqzl XuPpU9Lw7kD8DPCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Rei23nCb; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ALbbN7oc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774939746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FBmZqanWzzO95bjwHmnj9CTux+gNlouDU/+S5j9zoCY=; b=Rei23nCbN7eDS2cgYd9yeDoAxCDDCRxdlq/Vr+lxw7nibqIYv0Jv6aFOBZPtOKbKM3ZfxG K/G7g+12xcJs5SfXl80xUOgJsRm15tyve5wxeOxci7T9r1g9+MaErSNfLwtRAr2BJ2K45l nItovbgIkAHpPr/G99iA405sw6NFtKw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774939746; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FBmZqanWzzO95bjwHmnj9CTux+gNlouDU/+S5j9zoCY=; b=ALbbN7oca+kiPjxC/WEJ9sOpQEumHk2YvlffFrETF33EgFwLA6KtjLch9tCyIKLKgfKqzl XuPpU9Lw7kD8DPCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6A2394A0A2 for ; Tue, 31 Mar 2026 06:49:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0IOgGGJuy2lQMAAAD6G6ig (envelope-from ) for ; Tue, 31 Mar 2026 06:49:06 +0000 Message-ID: <55fe735c-ed0f-4efe-a7b1-81c6ac52528c@suse.de> Date: Tue, 31 Mar 2026 08:49:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Reformat gdb.ada using tclfmt From: Tom de Vries To: gdb-patches@sourceware.org References: <20260325161319.4092668-1-tdevries@suse.de> <20260325161319.4092668-3-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20260325161319.4092668-3-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 7B9C75BE9B X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/25/26 5:13 PM, Tom de Vries wrote: > [1]https://github.com/nmoroze/tclint/issues/160 > [2]https://github.com/nmoroze/tclint/issues/140 These two issues have been fixed upstream. > Likewise in: > - gdb.ada/data-sections.exp This file contains: ... if {[gdb_compile_ada "${srcfile}" "${binfile}" executable \ {debug additional_flags=-fdata-sections ldflags=-Wl,--gc-sections}] \ != ""} { return } ... Now that issue #140 has been fixed, tclfmt rewrites this to: ... if {[gdb_compile_ada "${srcfile}" "${binfile}" executable \ {debug additional_flags=-fdata-sections ldflags=-Wl,--gc-sections}] != ""} { return } ... in other words, dropping the backslash at the end of the line. The resulting formatting is also emacs-stable, that is, emacs auto-indent doesn't change it, but IWBN if tclfmt kept the same formatting. I've filed an issue about it ( https://github.com/nmoroze/tclint/ issues/162 ). Thanks, - Tom