From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step
Date: Wed, 09 Sep 2015 15:37:00 -0000 [thread overview]
Message-ID: <55F05250.2020300@ericsson.com> (raw)
In-Reply-To: <1441096915-23615-2-git-send-email-yao.qi@linaro.org>
> - /* Although lynx has hardware single step, still disable this
> - feature for lynx, because it is implemented in linux-low.c instead
> - of in generic code. */
> - NULL, /* supports_conditional_breakpoints */
> + target_can_do_hardware_single_step,
> NULL, /* stopped_by_watchpoint */
> NULL, /* stopped_data_address */
> NULL, /* read_offsets */
...
> +
> +/* Target can do hardware single step. */
> +
> +int
> +target_can_do_hardware_single_step (void)
> +{
> + return 1;
> +}
Why would we enable conditional breakpoints on lynx,win32 etc.. since I
think it's still valid that it's implemented in linux-low ?
Should we not default to return 0 in target_can_do_hardware_single_step ?
next prev parent reply other threads:[~2015-09-09 15:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 8:42 [PATCH 0/2 V2] Support single step by arch or target Yao Qi
2015-09-01 8:42 ` [PATCH 2/2] " Yao Qi
2015-09-01 13:18 ` Antoine Tremblay
2015-09-01 14:23 ` Yao Qi
2015-09-01 15:30 ` Antoine Tremblay
2015-09-01 14:40 ` Eli Zaretskii
2015-09-04 14:46 ` Antoine Tremblay
2015-09-14 8:18 ` Yao Qi
2015-09-15 13:31 ` Pedro Alves
2015-09-01 8:42 ` [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step Yao Qi
2015-09-02 19:22 ` Antoine Tremblay
2015-09-03 15:13 ` Antoine Tremblay
2015-09-04 14:40 ` Antoine Tremblay
2015-09-04 15:04 ` Antoine Tremblay
2015-09-08 14:32 ` Yao Qi
2015-09-08 19:01 ` Antoine Tremblay
2015-09-09 15:37 ` Antoine Tremblay [this message]
2015-09-15 13:11 ` [PATCH 0/2 V2] Support single step by arch or target Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F05250.2020300@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox