Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step
Date: Wed, 02 Sep 2015 19:22:00 -0000	[thread overview]
Message-ID: <55E74C68.8020608@ericsson.com> (raw)
In-Reply-To: <1441096915-23615-2-git-send-email-yao.qi@linaro.org>


On 09/01/2015 04:41 AM, Yao Qi wrote:
> In my patch https://sourceware.org/ml/gdb-patches/2015-04/msg01110.html
> a new target_ops hook supports_conditional_breakpoints was added to
> disable conditional breakpoints if target doesn't have hardware single
> step.  This patch is to generalize this hook from
> supports_conditional_breakpoints to supports_hardware_single_step,
> so that the following patch can use it.
>

Could we generalize this even more to supports_single_step like your 
next patch ?

Since I'm working on software single stepping for ARM, if this patch 
goes in I'll need to implement a supports_software_single_step and 
enable ConditionalBreakpoints for this case too...

Is there a need to know that it's really hardware or just knowing that 
it can single step would be ok ?

Regards,
Antoine


  reply	other threads:[~2015-09-02 19:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01  8:42 [PATCH 0/2 V2] Support single step by arch or target Yao Qi
2015-09-01  8:42 ` [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step Yao Qi
2015-09-02 19:22   ` Antoine Tremblay [this message]
2015-09-03 15:13     ` Antoine Tremblay
2015-09-04 14:40       ` Antoine Tremblay
2015-09-04 15:04         ` Antoine Tremblay
2015-09-08 14:32     ` Yao Qi
2015-09-08 19:01       ` Antoine Tremblay
2015-09-09 15:37   ` Antoine Tremblay
2015-09-01  8:42 ` [PATCH 2/2] Support single step by arch or target Yao Qi
2015-09-01 13:18   ` Antoine Tremblay
2015-09-01 14:23     ` Yao Qi
2015-09-01 15:30       ` Antoine Tremblay
2015-09-01 14:40   ` Eli Zaretskii
2015-09-04 14:46   ` Antoine Tremblay
2015-09-14  8:18     ` Yao Qi
2015-09-15 13:31   ` Pedro Alves
2015-09-15 13:11 ` [PATCH 0/2 V2] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E74C68.8020608@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox