Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Support single step by arch or target
Date: Tue, 15 Sep 2015 13:31:00 -0000	[thread overview]
Message-ID: <55F81DBA.7040105@redhat.com> (raw)
In-Reply-To: <1441096915-23615-3-git-send-email-yao.qi@linaro.org>

On 09/01/2015 09:41 AM, Yao Qi wrote:
> +@item vContSupported
> +This feature indicates whether @value{GDBN} wants to know the
> +supported actions in the reply to @samp{vCont?} packet.
>  @end table
>  

I find this confusing, because vCont? is already supposed
to return the supported vCont actions:

 @item vCont?
 @cindex @samp{vCont?} packet
 Request a list of actions supported by the @samp{vCont} packet.

So ISTM that in the perspective of someone reading the manual without
the context we're discussing here, it's not clear at all what
vContSupported is supposed to mean and why not simply always
return the supported vCont actions in reply to vCont?

Is there an advantage to the vContSupported indirection?  I was
originally thinking we'd make the server report "vCont=c;C;t;s;S;r"
directly in its qSupported reply, and gdb would stop using "vCont?"
going forward (if the target supports that qSupported feature).

Thanks,
Pedro Alves


  parent reply	other threads:[~2015-09-15 13:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01  8:42 [PATCH 0/2 V2] " Yao Qi
2015-09-01  8:42 ` [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step Yao Qi
2015-09-02 19:22   ` Antoine Tremblay
2015-09-03 15:13     ` Antoine Tremblay
2015-09-04 14:40       ` Antoine Tremblay
2015-09-04 15:04         ` Antoine Tremblay
2015-09-08 14:32     ` Yao Qi
2015-09-08 19:01       ` Antoine Tremblay
2015-09-09 15:37   ` Antoine Tremblay
2015-09-01  8:42 ` [PATCH 2/2] Support single step by arch or target Yao Qi
2015-09-01 13:18   ` Antoine Tremblay
2015-09-01 14:23     ` Yao Qi
2015-09-01 15:30       ` Antoine Tremblay
2015-09-01 14:40   ` Eli Zaretskii
2015-09-04 14:46   ` Antoine Tremblay
2015-09-14  8:18     ` Yao Qi
2015-09-15 13:31   ` Pedro Alves [this message]
2015-09-15 13:11 ` [PATCH 0/2 V2] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F81DBA.7040105@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox