From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14474 invoked by alias); 2 Sep 2015 19:22:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14457 invoked by uid 89); 2 Sep 2015 19:22:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 02 Sep 2015 19:22:19 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 91.FB.26730.232E6E55; Wed, 2 Sep 2015 13:49:06 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.248.2; Wed, 2 Sep 2015 15:22:16 -0400 Subject: Re: [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step To: Yao Qi , References: <1441096915-23615-1-git-send-email-yao.qi@linaro.org> <1441096915-23615-2-git-send-email-yao.qi@linaro.org> From: Antoine Tremblay Message-ID: <55E74C68.8020608@ericsson.com> Date: Wed, 02 Sep 2015 19:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441096915-23615-2-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00045.txt.bz2 On 09/01/2015 04:41 AM, Yao Qi wrote: > In my patch https://sourceware.org/ml/gdb-patches/2015-04/msg01110.html > a new target_ops hook supports_conditional_breakpoints was added to > disable conditional breakpoints if target doesn't have hardware single > step. This patch is to generalize this hook from > supports_conditional_breakpoints to supports_hardware_single_step, > so that the following patch can use it. > Could we generalize this even more to supports_single_step like your next patch ? Since I'm working on software single stepping for ARM, if this patch goes in I'll need to implement a supports_software_single_step and enable ConditionalBreakpoints for this case too... Is there a need to know that it's really hardware or just knowing that it can single step would be ok ? Regards, Antoine