From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125895-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 108845 invoked by alias); 9 Sep 2015 15:37:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 108836 invoked by uid 89); 9 Sep 2015 15:37:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: usevmg21.ericsson.net
Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 09 Sep 2015 15:37:55 +0000
Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87])	by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 03.79.26730.0C7EFE55; Wed,  9 Sep 2015 10:03:13 +0200 (CEST)
Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Wed, 9 Sep 2015 11:37:52 -0400
Subject: Re: [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step
To: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
References: <1441096915-23615-1-git-send-email-yao.qi@linaro.org> <1441096915-23615-2-git-send-email-yao.qi@linaro.org>
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
Message-ID: <55F05250.2020300@ericsson.com>
Date: Wed, 09 Sep 2015 15:37:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1441096915-23615-2-git-send-email-yao.qi@linaro.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-09/txt/msg00135.txt.bz2


> -  /* Although lynx has hardware single step, still disable this
> -     feature for lynx, because it is implemented in linux-low.c instead
> -     of in generic code.  */
> -  NULL,  /* supports_conditional_breakpoints */
> +  target_can_do_hardware_single_step,
>     NULL,  /* stopped_by_watchpoint */
>     NULL,  /* stopped_data_address */
>     NULL,  /* read_offsets */
...
> +
> +/* Target can do hardware single step.  */
> +
> +int
> +target_can_do_hardware_single_step (void)
> +{
> +  return 1;
> +}

Why would we enable conditional breakpoints on lynx,win32 etc.. since I 
think it's still valid that it's implemented in linux-low ?

Should we not default to return 0 in target_can_do_hardware_single_step ?