Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.

[Antoine Tremblay <antoine.tremblay@ericsson.com>]

On 08/04/2015 10:18 AM, Antoine Tremblay wrote:
> On 08/04/2015 06:18 AM, Yao Qi wrote:
>> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>>
>> Hi Antoine, I am lost in the description of your patch.
>>
>>> Without this patch, when doing a software single step, with for example
>>> a conditional breakpoint, gdbserver would wrongly avance the pc of
>>> breakpoint_len and skip an instruction.
>>
>> GDBserver doesn't support software single step.  Does your patch fix
>> some bug in current GDBserver or in GDBserver with software single step
>> enabled?  If it is the latter, then, you need to include this patch
>> in your patch series supporting software single step in GDBserver,
>> rather than sending it separately.
>>
>
> It does support it for mips,sparc,nios2,cris,crisv32 if I do a grep from
> reinsert_addr...
>
> can_hardware_single_step will return false for these ones...
>
> Unless I've missed something ?
>

Indeed after careful review, all these arch do not support software 
breakpoints and since conditional breakpoints are not supported either 
they will not software single step.

I will repost the patch with my next patchset...