From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120598 invoked by alias); 4 Aug 2015 14:39:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120588 invoked by uid 89); 4 Aug 2015 14:39:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 04 Aug 2015 14:39:31 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id CD.B4.12958.D0270C55; Tue, 4 Aug 2015 10:04:29 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.210.2; Tue, 4 Aug 2015 10:39:29 -0400 Message-ID: <55C0CEA0.7080805@ericsson.com> Date: Tue, 04 Aug 2015 14:39:00 -0000 From: Antoine Tremblay User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Yao Qi CC: Subject: Re: [PATCH] Fix instruction skipping when using software single step in gdbserver. References: <1438353367-24936-1-git-send-email-antoine.tremblay@ericsson.com> <861tfje4qq.fsf@gmail.com> <55C0C9C8.2010102@ericsson.com> In-Reply-To: <55C0C9C8.2010102@ericsson.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00075.txt.bz2 On 08/04/2015 10:18 AM, Antoine Tremblay wrote: > On 08/04/2015 06:18 AM, Yao Qi wrote: >> Antoine Tremblay writes: >> >> Hi Antoine, I am lost in the description of your patch. >> >>> Without this patch, when doing a software single step, with for example >>> a conditional breakpoint, gdbserver would wrongly avance the pc of >>> breakpoint_len and skip an instruction. >> >> GDBserver doesn't support software single step. Does your patch fix >> some bug in current GDBserver or in GDBserver with software single step >> enabled? If it is the latter, then, you need to include this patch >> in your patch series supporting software single step in GDBserver, >> rather than sending it separately. >> > > It does support it for mips,sparc,nios2,cris,crisv32 if I do a grep from > reinsert_addr... > > can_hardware_single_step will return false for these ones... > > Unless I've missed something ? > Indeed after careful review, all these arch do not support software breakpoints and since conditional breakpoints are not supported either they will not software single step. I will repost the patch with my next patchset...