From: Joel Brobecker <brobecker@adacore.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.
Date: Tue, 04 Aug 2015 17:18:00 -0000 [thread overview]
Message-ID: <20150804171823.GH4777@adacore.com> (raw)
In-Reply-To: <1438353367-24936-1-git-send-email-antoine.tremblay@ericsson.com>
Just a small trivial comment while scanning the patch...
> --- a/gdb/gdbserver/mem-break.c
> +++ b/gdb/gdbserver/mem-break.c
> @@ -1660,6 +1660,21 @@ hardware_breakpoint_inserted_here (CORE_ADDR addr)
> return 0;
> }
>
> +int
> +reinsert_breakpoint_inserted_here (CORE_ADDR addr)
Can you add the standard bread crumb comment that indicates that
the function is in fact documented, and where that documentation
is? Eg:
/* See mem-break.h. */
Thank you! :)
--
Joel
next prev parent reply other threads:[~2015-08-04 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 14:36 Antoine Tremblay
2015-08-04 10:18 ` Yao Qi
2015-08-04 14:18 ` Antoine Tremblay
2015-08-04 14:39 ` Antoine Tremblay
2015-08-04 17:18 ` Joel Brobecker [this message]
2015-08-04 18:41 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804171823.GH4777@adacore.com \
--to=brobecker@adacore.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox