From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.
Date: Tue, 04 Aug 2015 14:18:00 -0000 [thread overview]
Message-ID: <55C0C9C8.2010102@ericsson.com> (raw)
In-Reply-To: <861tfje4qq.fsf@gmail.com>
On 08/04/2015 06:18 AM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
> Hi Antoine, I am lost in the description of your patch.
>
>> Without this patch, when doing a software single step, with for example
>> a conditional breakpoint, gdbserver would wrongly avance the pc of
>> breakpoint_len and skip an instruction.
>
> GDBserver doesn't support software single step. Does your patch fix
> some bug in current GDBserver or in GDBserver with software single step
> enabled? If it is the latter, then, you need to include this patch
> in your patch series supporting software single step in GDBserver,
> rather than sending it separately.
>
It does support it for mips,sparc,nios2,cris,crisv32 if I do a grep from
reinsert_addr...
can_hardware_single_step will return false for these ones...
Unless I've missed something ?
next prev parent reply other threads:[~2015-08-04 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 14:36 Antoine Tremblay
2015-08-04 10:18 ` Yao Qi
2015-08-04 14:18 ` Antoine Tremblay [this message]
2015-08-04 14:39 ` Antoine Tremblay
2015-08-04 17:18 ` Joel Brobecker
2015-08-04 18:41 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C0C9C8.2010102@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox