From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56176 invoked by alias); 4 Aug 2015 17:18:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56108 invoked by uid 89); 4 Aug 2015 17:18:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 04 Aug 2015 17:18:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 56E9411D655; Tue, 4 Aug 2015 13:18:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HfUgFtXEQsQP; Tue, 4 Aug 2015 13:18:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D0FAA11D651; Tue, 4 Aug 2015 13:18:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5A9C1472E5; Tue, 4 Aug 2015 10:18:23 -0700 (PDT) Date: Tue, 04 Aug 2015 17:18:00 -0000 From: Joel Brobecker To: Antoine Tremblay Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix instruction skipping when using software single step in gdbserver. Message-ID: <20150804171823.GH4777@adacore.com> References: <1438353367-24936-1-git-send-email-antoine.tremblay@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438353367-24936-1-git-send-email-antoine.tremblay@ericsson.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-08/txt/msg00093.txt.bz2 Just a small trivial comment while scanning the patch... > --- a/gdb/gdbserver/mem-break.c > +++ b/gdb/gdbserver/mem-break.c > @@ -1660,6 +1660,21 @@ hardware_breakpoint_inserted_here (CORE_ADDR addr) > return 0; > } > > +int > +reinsert_breakpoint_inserted_here (CORE_ADDR addr) Can you add the standard bread crumb comment that indicates that the function is in fact documented, and where that documentation is? Eg: /* See mem-break.h. */ Thank you! :) -- Joel