Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378)

[Pedro Alves <palves@redhat.com>]

On 06/30/2015 06:10 PM, Patrick Palka wrote:

>> Hmm, what about when the user changes registers with "print $rax = 1" etc.?
>> Do we end up with stale contents?
> 
> Apparently not, thanks to our deprecated_register_changed_hook called
> from value_assign.  So many hooks!

Phew!  And luckily there's an equivalent registers_changed observer
we could use instead too.

Patch is OK, just please mention tui_register_changed_hook ...

> +/* Observer for the before_prompt notification.  */
> +
> +static void
> +tui_before_prompt (const char *current_gdb_prompt)
> +{
> +  /* This refresh is intended to catch changes to the selected frame following
> +     a call to "up", "down" or "frame".  As such we don't necessarily want to
> +     refresh registers here as they could not have changed.  Registers will be
> +     refreshed after a normal stop.  */

... here too.

Awesome.  Glad that this is finally fixed.

Thanks,
Pedro Alves