From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104053 invoked by alias); 30 Jun 2015 17:32:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104033 invoked by uid 89); 30 Jun 2015 17:32:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 17:32:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 3C64174; Tue, 30 Jun 2015 17:32:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5UHW8ke020136; Tue, 30 Jun 2015 13:32:09 -0400 Message-ID: <5592D298.6090804@redhat.com> Date: Tue, 30 Jun 2015 17:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) References: <5592B9F9.2090208@redhat.com> <1435682400-7595-1-git-send-email-patrick@parcs.ath.cx> <5592CCC7.5080101@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00658.txt.bz2 On 06/30/2015 06:10 PM, Patrick Palka wrote: >> Hmm, what about when the user changes registers with "print $rax = 1" etc.? >> Do we end up with stale contents? > > Apparently not, thanks to our deprecated_register_changed_hook called > from value_assign. So many hooks! Phew! And luckily there's an equivalent registers_changed observer we could use instead too. Patch is OK, just please mention tui_register_changed_hook ... > +/* Observer for the before_prompt notification. */ > + > +static void > +tui_before_prompt (const char *current_gdb_prompt) > +{ > + /* This refresh is intended to catch changes to the selected frame following > + a call to "up", "down" or "frame". As such we don't necessarily want to > + refresh registers here as they could not have changed. Registers will be > + refreshed after a normal stop. */ ... here too. Awesome. Glad that this is finally fixed. Thanks, Pedro Alves