From: Patrick Palka <patrick@parcs.ath.cx>
To: gdb-patches@sourceware.org
Cc: Patrick Palka <patrick@parcs.ath.cx>
Subject: [PATCH 1/3] Correctly initialize the TUI locator window
Date: Sat, 27 Jun 2015 02:35:00 -0000 [thread overview]
Message-ID: <1435372525-1374-1-git-send-email-patrick@parcs.ath.cx> (raw)
The call to tui_alloc_content in tui_set_locator_info passes
locator->type as the type of the window whose content is being
allocated. This may seem correct but it's actually not because when
this code path actually get executed locator->type has not yet been to
set LOCATOR_WIN so it defaults to 0 i.e. SRC_WIN. Thus we allocate the
content of the locator window as if it was the source window. This
oversight turns out not to be a big deal in practice but the patch that
follows depends on the locator's proc_name and full_name arrays to be
initialized to the empty string which is done by tui_alloc_content if
we pass to it LOCATOR_WIN.
This patch fixes this bug by explicitly passing LOCATOR_WIN to
tui_alloc_content.
gdb/ChangeLog:
* tui/tui-stack.c (tui_set_locator_info): Explicitly pass
LOCATOR_WIN to tui_alloc_content.
---
gdb/tui/tui-stack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c
index 2870d70..b17d303 100644
--- a/gdb/tui/tui-stack.c
+++ b/gdb/tui/tui-stack.c
@@ -306,7 +306,7 @@ tui_set_locator_info (struct gdbarch *gdbarch,
/* Allocate the locator content if necessary. */
if (locator->content_size <= 0)
{
- locator->content = tui_alloc_content (1, locator->type);
+ locator->content = tui_alloc_content (1, LOCATOR_WIN);
locator->content_size = 1;
}
--
2.5.0.rc0.5.g91e10c5.dirty
next reply other threads:[~2015-06-27 2:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 2:35 Patrick Palka [this message]
2015-06-27 2:35 ` [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) Patrick Palka
2015-06-27 2:50 ` Patrick Palka
2015-06-30 9:32 ` Pedro Alves
2015-06-30 12:16 ` Patrick Palka
2015-06-30 12:37 ` Patrick Palka
2015-06-30 14:08 ` Pedro Alves
2015-06-30 14:54 ` Patrick Palka
2015-06-30 14:56 ` Patrick Palka
2015-06-30 15:12 ` Patrick Palka
2015-06-30 15:47 ` Pedro Alves
2015-06-30 16:40 ` Patrick Palka
2015-06-30 17:07 ` Pedro Alves
2015-06-30 17:11 ` Patrick Palka
2015-06-30 17:32 ` Pedro Alves
2015-06-30 17:49 ` Patrick Palka
2015-07-01 12:40 ` Patrick Palka
2015-06-30 13:23 ` Pedro Alves
2015-06-30 14:03 ` Patrick Palka
2015-06-27 2:35 ` [PATCH 2/3] Be lazy about refreshing the windows in tui_show_frame_info " Patrick Palka
2015-06-30 2:32 ` [PATCH] " Patrick Palka
2015-06-30 14:27 ` Pedro Alves
2015-06-30 14:45 ` Patrick Palka
2015-06-30 15:11 ` Pedro Alves
2015-06-30 15:15 ` Patrick Palka
2015-06-30 16:51 ` [PATCH 2/3] " Patrick Palka
2015-06-30 17:26 ` Pedro Alves
2015-06-30 8:36 ` [PATCH 1/3] Correctly initialize the TUI locator window Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435372525-1374-1-git-send-email-patrick@parcs.ath.cx \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox