From: Pedro Alves <palves@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: eliminate deprecated_insert_raw_breakpoint. what's left.
Date: Mon, 08 Sep 2014 17:46:00 -0000 [thread overview]
Message-ID: <540DEB7E.3000100@redhat.com> (raw)
Hey,
I'm working on a patch that converts software single-step breakpoints
to real breakpoints. It's largely done, but needs a bit of cleaning up
before I'll post it. One issue is that software single-step breakpoints
were implemented on top of deprecated_insert_raw_breakpoint. They no
longer are after my patch, but we're still left with some ugly code in
breakpoint.c related to deprecated_insert_raw_breakpoints on top of other
breakpoints that I'd like to eliminate completely, but that can only
be done once all users of deprecated_insert_raw_breakpoint are either converted
to some more modern mechanism, or eliminated.
Before I go spend some effort blindly trying to do these remaining
conversions, I thought I'd run them through the list first, in case some
of this code can be considered dead already, or in case someone can
lend a hand (which would be awesome).
The remaining users are:
procfs.c: dbx_link_bpt = deprecated_insert_raw_breakpoint (target_gdbarch (), NULL,
This is only compiled if SYS_syssgi is defined, which I believe means
MIPS IRIX. Do we still care about MIPS IRIX?
solib-irix.c: base_breakpoint = deprecated_insert_raw_breakpoint (target_gdbarch (),
This could/should probably be converted to use create_solib_event_breakpoint.
Though see above.
rs6000-nat.c: bp = deprecated_insert_raw_breakpoint (gdbarch, NULL, DUMMY_INSN_ADDR);
This is AIX code. Looks like this can easily be converted to a momentary breakpoint?
AFAIR, I have no way to test either AIX or IRIX.
Thanks,
Pedro Alves
next reply other threads:[~2014-09-08 17:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 17:46 Pedro Alves [this message]
2014-09-08 19:24 ` Joel Brobecker
2014-09-08 21:34 ` Joel Brobecker
2014-09-08 22:50 ` Pedro Alves
2014-09-09 0:25 ` Peter Schauer
2014-09-09 0:16 ` Peter Schauer
2014-09-09 11:39 ` Ulrich Weigand
2014-09-09 12:38 ` Peter Schauer
2014-09-09 21:25 ` Ulrich Weigand
2014-09-10 12:21 ` Joel Brobecker
2014-09-10 13:15 ` Ulrich Weigand
2014-09-10 15:22 ` Pedro Alves
2014-09-09 21:48 ` Ulrich Weigand
2014-09-10 12:29 ` Joel Brobecker
2014-09-10 14:45 ` Ulrich Weigand
2014-09-10 15:21 ` Pedro Alves
2014-09-10 15:50 ` Maciej W. Rozycki
2014-09-10 16:12 ` [IRIX] eliminate deprecated_insert_raw_breakpoint uses Pedro Alves
2014-09-10 22:44 ` Joel Brobecker
2014-09-10 23:02 ` Pedro Alves
2014-09-11 3:27 ` Joel Brobecker
2014-09-12 19:34 ` Pedro Alves
2014-09-12 20:23 ` Joel Brobecker
2014-09-10 15:50 ` eliminate deprecated_insert_raw_breakpoint. what's left Joel Brobecker
2014-09-10 16:00 ` Sergio Durigan Junior
2014-09-10 16:36 ` Ulrich Weigand
2014-09-10 18:59 ` New deprecation procedure Pedro Alves
2014-09-11 19:03 ` Joel Brobecker
2014-09-12 8:51 ` Ulrich Weigand
2014-10-07 0:25 ` eliminate deprecated_insert_raw_breakpoint. what's left Stan Shebs
2014-09-09 17:33 ` Pedro Alves
[not found] <alpine.DEB.1.10.1409101553070.27075@tp.orcam.me.uk>
2014-09-10 16:45 ` Ulrich Weigand
2014-09-10 19:11 ` Maciej W. Rozycki
2014-09-11 11:50 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540DEB7E.3000100@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox