From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23068 invoked by alias); 8 Sep 2014 17:46:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22969 invoked by uid 89); 8 Sep 2014 17:46:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Sep 2014 17:46:41 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s88Hkddc011668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 8 Sep 2014 13:46:40 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s88HkcOc031896 for ; Mon, 8 Sep 2014 13:46:39 -0400 Message-ID: <540DEB7E.3000100@redhat.com> Date: Mon, 08 Sep 2014 17:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: GDB Patches Subject: eliminate deprecated_insert_raw_breakpoint. what's left. Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00202.txt.bz2 Hey, I'm working on a patch that converts software single-step breakpoints to real breakpoints. It's largely done, but needs a bit of cleaning up before I'll post it. One issue is that software single-step breakpoints were implemented on top of deprecated_insert_raw_breakpoint. They no longer are after my patch, but we're still left with some ugly code in breakpoint.c related to deprecated_insert_raw_breakpoints on top of other breakpoints that I'd like to eliminate completely, but that can only be done once all users of deprecated_insert_raw_breakpoint are either converted to some more modern mechanism, or eliminated. Before I go spend some effort blindly trying to do these remaining conversions, I thought I'd run them through the list first, in case some of this code can be considered dead already, or in case someone can lend a hand (which would be awesome). The remaining users are: procfs.c: dbx_link_bpt = deprecated_insert_raw_breakpoint (target_gdbarch (), NULL, This is only compiled if SYS_syssgi is defined, which I believe means MIPS IRIX. Do we still care about MIPS IRIX? solib-irix.c: base_breakpoint = deprecated_insert_raw_breakpoint (target_gdbarch (), This could/should probably be converted to use create_solib_event_breakpoint. Though see above. rs6000-nat.c: bp = deprecated_insert_raw_breakpoint (gdbarch, NULL, DUMMY_INSN_ADDR); This is AIX code. Looks like this can easily be converted to a momentary breakpoint? AFAIR, I have no way to test either AIX or IRIX. Thanks, Pedro Alves