Re: eliminate deprecated_insert_raw_breakpoint. what's left.

[Joel Brobecker <brobecker@adacore.com>]

> > This is AIX code.  Looks like this can easily be converted to a
> > momentary breakpoint?
> 
> I am actually wondering whether this is still needed. It could!
> So, the first thing I wanted to do was to run the testsuite without.
> I'm currently building GDB, which is taking forever, and will then
> run AdaCore's testsuite.

Looking at the code, it should be executed each time the SP register
gets changed, which means it should trigger when calling functions
from GDB. Deactivating exec_one_dummy_insn entirely did not result
in any regression I could notice. That was on AIX 7.1.

That being said, I'm hesitant of removing the code regardless,
since this could only be needed in specific situations which might
not be covered by the testsuites we have.

I was looking at how to replace that call, but I am not sure
how to fix the code up, though. Perhaps we could just write
the breakpoint instruction in by hand, rather than go through
the breakpoint module? After all, it is already doing almost
everything else by hand!

In fact, looking at the code again now, I'm a little more tempted
to see what happens if we remove it ;-).

-- 
Joel