From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6516 invoked by alias); 8 Sep 2014 21:34:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6505 invoked by uid 89); 8 Sep 2014 21:34:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 08 Sep 2014 21:34:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B9ABF116358; Mon, 8 Sep 2014 17:34:26 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ILUirzsrs+X6; Mon, 8 Sep 2014 17:34:26 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8EFA3116347; Mon, 8 Sep 2014 17:34:26 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8DF9047592; Mon, 8 Sep 2014 14:34:27 -0700 (PDT) Date: Mon, 08 Sep 2014 21:34:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: GDB Patches Subject: Re: eliminate deprecated_insert_raw_breakpoint. what's left. Message-ID: <20140908213427.GF28404@adacore.com> References: <540DEB7E.3000100@redhat.com> <20140908192432.GE28404@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140908192432.GE28404@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00206.txt.bz2 > > This is AIX code. Looks like this can easily be converted to a > > momentary breakpoint? > > I am actually wondering whether this is still needed. It could! > So, the first thing I wanted to do was to run the testsuite without. > I'm currently building GDB, which is taking forever, and will then > run AdaCore's testsuite. Looking at the code, it should be executed each time the SP register gets changed, which means it should trigger when calling functions from GDB. Deactivating exec_one_dummy_insn entirely did not result in any regression I could notice. That was on AIX 7.1. That being said, I'm hesitant of removing the code regardless, since this could only be needed in specific situations which might not be covered by the testsuites we have. I was looking at how to replace that call, but I am not sure how to fix the code up, though. Perhaps we could just write the breakpoint instruction in by hand, rather than go through the breakpoint module? After all, it is already doing almost everything else by hand! In fact, looking at the code again now, I'm a little more tempted to see what happens if we remove it ;-). -- Joel