Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram
Date: Fri, 22 Aug 2014 16:41:00 -0000	[thread overview]
Message-ID: <53F77297.80704@redhat.com> (raw)
In-Reply-To: <1408708971-15299-1-git-send-email-yao@codesourcery.com>

Hi Yao,

On 08/22/2014 01:02 PM, Yao Qi wrote:

>  /* Read a partial die corresponding to a subprogram and create a partial
>     symbol for that subprogram.  When the CU language allows it, this
>     routine also defines a partial symbol for each nested subprogram
> -   that this subprogram contains.
> +   that this subprogram contains.  If SET_ADDRMAP is true, record the
> +   covered ranges in the addrmap.  *LOWPC and *HIGHPC to the lowest and
> +   highest PC values found in PDI.

The last sentence is missing the verb?

> -   DIE my also be a lexical block, in which case we simply search
> +   PDI may also be a lexical block, in which case we simply search
>     recursively for suprograms defined inside that lexical block.

As long as we're fixing typos, there's another here "suprograms".

Otherwise looks fine to me.

Thanks,
Pedro Alves


  reply	other threads:[~2014-08-22 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 12:07 Yao Qi
2014-08-22 16:41 ` Pedro Alves [this message]
2014-08-24 13:52   ` Yao Qi
2014-08-25  9:58     ` Pedro Alves
2014-08-25 12:13       ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F77297.80704@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox