Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram
Date: Mon, 25 Aug 2014 12:13:00 -0000	[thread overview]
Message-ID: <87egw4hite.fsf@codesourcery.com> (raw)
In-Reply-To: <53FB08A4.2060609@redhat.com> (Pedro Alves's message of "Mon, 25	Aug 2014 10:57:56 +0100")

Pedro Alves <palves@redhat.com> writes:

> Hmm.  I still can't parse this though.  It's actually the "to the" part
> that seems to miss a verb to me.  Isn't a "Set" missing instead of
> "are"?  Like:
>
>   that this subprogram contains.  If SET_ADDRMAP is true, record the
>   covered ranges in the addrmap.  Set *LOWPC and *HIGHPC to the lowest and
>   highest PC values found in PDI.

Sigh, my brain stopped working!  Sorry about that.  Fix it as you suggested.

-- 
Yao (齐尧)

commit 9afcfde91565f7fa16e77794cef0a05ebe77bf1b
Author: Yao Qi <yao@codesourcery.com>
Date:   Mon Aug 25 20:01:45 2014 +0800

    Fix grammatical error in comments
    
    gdb:
    
    2014-08-25  Yao Qi  <yao@codesourcery.com>
    
    	* dwarf2read.c: Fix grammatical error.

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index df6deef..4720198 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -7007,8 +7007,8 @@ add_partial_module (struct partial_die_info *pdi, CORE_ADDR *lowpc,
    symbol for that subprogram.  When the CU language allows it, this
    routine also defines a partial symbol for each nested subprogram
    that this subprogram contains.  If SET_ADDRMAP is true, record the
-   covered ranges in the addrmap.  *LOWPC and *HIGHPC to the lowest and
-   highest PC values are found in PDI.
+   covered ranges in the addrmap.  Set *LOWPC and *HIGHPC to the lowest
+   and highest PC values found in PDI.
 
    PDI may also be a lexical block, in which case we simply search
    recursively for subprograms defined inside that lexical block.


      reply	other threads:[~2014-08-25 12:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 12:07 Yao Qi
2014-08-22 16:41 ` Pedro Alves
2014-08-24 13:52   ` Yao Qi
2014-08-25  9:58     ` Pedro Alves
2014-08-25 12:13       ` Yao Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egw4hite.fsf@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox