From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram
Date: Mon, 25 Aug 2014 09:58:00 -0000 [thread overview]
Message-ID: <53FB08A4.2060609@redhat.com> (raw)
In-Reply-To: <87lhqegfrt.fsf@codesourcery.com>
On 08/24/2014 02:48 PM, Yao Qi wrote:
>>> >> - that this subprogram contains.
>>> >> + that this subprogram contains. If SET_ADDRMAP is true, record the
>>> >> + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
>>> >> + highest PC values found in PDI.
>> >
>> > The last sentence is missing the verb?
> Ur, "are" is missing, I think. It should be "... are found in PDI.".
> Fixed in the updated patch.
...
> + that this subprogram contains. If SET_ADDRMAP is true, record the
> + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and
> + highest PC values are found in PDI.
Hmm. I still can't parse this though. It's actually the "to the" part
that seems to miss a verb to me. Isn't a "Set" missing instead of
"are"? Like:
that this subprogram contains. If SET_ADDRMAP is true, record the
covered ranges in the addrmap. Set *LOWPC and *HIGHPC to the lowest and
highest PC values found in PDI.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-08-25 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 12:07 Yao Qi
2014-08-22 16:41 ` Pedro Alves
2014-08-24 13:52 ` Yao Qi
2014-08-25 9:58 ` Pedro Alves [this message]
2014-08-25 12:13 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB08A4.2060609@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox