From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23948 invoked by alias); 22 Aug 2014 16:41:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23937 invoked by uid 89); 22 Aug 2014 16:41:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 Aug 2014 16:41:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7MGevYx010048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Aug 2014 12:40:57 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7MGetbe025039; Fri, 22 Aug 2014 12:40:56 -0400 Message-ID: <53F77297.80704@redhat.com> Date: Fri, 22 Aug 2014 16:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Update comments in scan_partial_symbols and add_partial_subprogram References: <1408708971-15299-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1408708971-15299-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=yes Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00501.txt.bz2 Hi Yao, On 08/22/2014 01:02 PM, Yao Qi wrote: > /* Read a partial die corresponding to a subprogram and create a partial > symbol for that subprogram. When the CU language allows it, this > routine also defines a partial symbol for each nested subprogram > - that this subprogram contains. > + that this subprogram contains. If SET_ADDRMAP is true, record the > + covered ranges in the addrmap. *LOWPC and *HIGHPC to the lowest and > + highest PC values found in PDI. The last sentence is missing the verb? > - DIE my also be a lexical block, in which case we simply search > + PDI may also be a lexical block, in which case we simply search > recursively for suprograms defined inside that lexical block. As long as we're fixing typos, there's another here "suprograms". Otherwise looks fine to me. Thanks, Pedro Alves